Skip to content

doc: update zlib doc #31665

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from
Closed

doc: update zlib doc #31665

wants to merge 2 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 6, 2020

Just some general improvements to zlib docs and examples

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem. labels Feb 6, 2020
@jasnell jasnell requested a review from mcollina February 6, 2020 15:57
@jasnell jasnell requested a review from mcollina February 6, 2020 19:47
@jasnell
Copy link
Member Author

jasnell commented Feb 17, 2020

@Trott and @addaleax ... updated to address feedback. Please take another look :-)

@jasnell
Copy link
Member Author

jasnell commented Feb 24, 2020

Ping @Trott and @addaleax

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2020
@jasnell
Copy link
Member Author

jasnell commented Feb 26, 2020

Just some general improvements to zlib docs and examples

Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

jasnell added a commit that referenced this pull request Feb 27, 2020
Just some general improvements to zlib docs and examples

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Feb 27, 2020

Landed in c6ed01c

@jasnell jasnell closed this Feb 27, 2020
@Trott
Copy link
Member

Trott commented Feb 27, 2020

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4135/
First CI attempt failed...

Trying again: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4136/

Not sure if this was kicked off for some other reason and you already are aware of this, but just in case: FYI we changed the landing rules and lite CI is generally not needed anymore if Travis passed. #30330

codebytere pushed a commit that referenced this pull request Feb 27, 2020
Just some general improvements to zlib docs and examples

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Feb 29, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
Just some general improvements to zlib docs and examples

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
Just some general improvements to zlib docs and examples

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebytere codebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
Just some general improvements to zlib docs and examples

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants