[v13.x backport] pipeline destroy compat #32212
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
backport-32197-to-13.x
branch
from
6155d57
to
65f055c
Compare
2 tasks
|
fixed conflict |
ronag
force-pushed
the
backport-32197-to-13.x
branch
from
65f055c
to
4602189
Compare
|
I think something on v13.x-staging is failing CI (pre this PR). Building locally to try and help sort it out |
4 tasks
ronag
force-pushed
the
backport-32197-to-13.x
branch
from
7f4bc43
to
1d29d24
Compare
ronag
changed the title
This comment has been minimized.
This comment has been minimized.
|
Seems like CI is failing since f095e38 |
MylesBorins
force-pushed
the
v13.x-staging
branch
from
28cd36a
to
893e918
Compare
ronag
force-pushed
the
backport-32197-to-13.x
branch
from
1d29d24
to
8b274d1
Compare
http1 objects are coupled with their corresponding res/req and cannot be treated independently as normal streams. Add a special exception for this in the pipeline cleanup. Fixes: nodejs#32184 Backport-PR-URL: nodejs#32212
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. Fixes: nodejs@4d93e10#commitcomment-37751035 Backport-PR-URL: nodejs#32212
ronag
force-pushed
the
backport-32197-to-13.x
branch
from
8b274d1
to
ad0098d
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Mar 12, 2020
http1 objects are coupled with their corresponding res/req and cannot be treated independently as normal streams. Add a special exception for this in the pipeline cleanup. Fixes: #32184 Backport-PR-URL: #32212 PR-URL: #32197 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 12, 2020
User might still want to be able to use the writable side of src. This is in the case where e.g. the Duplex input is not directly connected to its output. Such a case could happen when the Duplex is reading from a socket and then echos the data back on the same socket. Backport-PR-URL: #32212 PR-URL: #32198 Refs: 4d93e10#commitcomment-37751035 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
landed in 77e5b50...fab8c83 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-URL: #32197
PR-URL: #32211
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes