Skip to content

doc: add Ruben to TSC #32213

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

doc: add Ruben to TSC #32213

wants to merge 2 commits into from

Conversation

mhdawson
Copy link
Member

Signed-off-by: Michael Dawson michael_dawson@ca.ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@mhdawson
doc: add Ruben to TSC
c2ddb86 
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 11, 2020
@mhdawson
Copy link
Member Author

@BridgeAR Welcome!

@mhdawson mhdawson mentioned this pull request Mar 11, 2020
Closed
@mhdawson
Copy link
Member Author

Fast Track ?

@mhdawson mhdawson added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 11, 2020
@mhdawson mhdawson added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2020
@mhdawson
Copy link
Member Author

Once CI is complete I think this can land based on the fast track process.

@ChALkeR ChALkeR requested a review from BridgeAR March 11, 2020 22:28
@BridgeAR
Copy link
Member

Thanks, you all!

gireeshpunathil
gireeshpunathil reviewed Mar 12, 2020
View reviewed changes
Trott pushed a commit that referenced this pull request Mar 12, 2020
@mhdawson @Trott
doc: add Ruben to TSC
e458747 
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Mar 12, 2020

Landed in e458747

@Trott Trott closed this Mar 12, 2020
BridgeAR pushed a commit that referenced this pull request Mar 17, 2020
@mhdawson @BridgeAR
doc: add Ruben to TSC
c5a3bfd 
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@mhdawson @MylesBorins
doc: add Ruben to TSC
19fee76 
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@mhdawson @targos
doc: add Ruben to TSC
c1c3aa1 
Signed-off-by: Michael Dawson <michael_dawson@ca.ibm.com>

PR-URL: #32213
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
@mhdawson mhdawson deleted the addRuben2 branch September 14, 2020 21:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ChALkeR ChALkeR ChALkeR approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

@mmarchini mmarchini mmarchini approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.