Skip to content

test: use Promise.all() in test-hash-seed #32273

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

test: use Promise.all() in test-hash-seed #32273

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 14, 2020

We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 14, 2020
@Trott
Copy link
Member Author

Trott commented Mar 15, 2020 •
edited
Loading

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12864/ ✅

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 15, 2020
@Trott
Copy link
Member Author

Trott commented Mar 17, 2020

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12912/

antsmartian
antsmartian approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@antsmartian antsmartian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Mar 18, 2020
@Trott
test: use Promise.all() in test-hash-seed
1a3c747 
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: nodejs#32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@Trott
Copy link
Member Author

Trott commented Mar 18, 2020

Landed in 1a3c747

@Trott Trott closed this Mar 18, 2020
@Trott Trott force-pushed the pummel-hash-seed branch from e8ba9f1 to 1a3c747 Compare March 18, 2020 01:30
@Trott Trott deleted the pummel-hash-seed branch March 18, 2020 01:30
MylesBorins pushed a commit that referenced this pull request Mar 19, 2020
@Trott @MylesBorins
test: use Promise.all() in test-hash-seed
7d1e170 
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: #32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 19, 2020
Merged
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@Trott @MylesBorins
test: use Promise.all() in test-hash-seed
05fd160 
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: #32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@Trott @targos
test: use Promise.all() in test-hash-seed
8dbd7cf 
We have several tests where a number of asynchronous processes need to
finish before some checks happen. These are done in a number of ways,
including (as here) using our Countdown testing module. I think
Promise.all() may be the idiomatic and ergonomic way to go for a lot of
these tests. Using this one to get feedback on the idea.

PR-URL: #32273
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@targos targos targos approved these changes

@jasnell jasnell jasnell approved these changes

@antsmartian antsmartian antsmartian approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @jasnell @antsmartian @targos @tniessen @nodejs-github-bot