Skip to content

doc: fix lint warning in doc/api/esm.md #32462

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

richardlau
Copy link
Member

#31479 landed on master with the following warning from the markdown linter:
https://github.com/nodejs/node/runs/531048109?check_suite_focus=true#step:4:6

doc/api/esm.md
  920:84  warning  Line must be at most 80 characters  maximum-line-length  remark-lint

Refs: #31479

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Signed-off-by: Richard Lau <riclau@uk.ibm.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Mar 24, 2020
@sam-github
Copy link
Contributor

Upvote to fast-track.

@sam-github sam-github added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 24, 2020
richardlau referenced this pull request Mar 24, 2020
PR-URL: #31479
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Geoffrey Booth <webmaster@geoffreybooth.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@ronag ronag mentioned this pull request Mar 24, 2020
4 tasks
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32462
Refs: #31479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins
Copy link
Contributor

Landed in 066bdec

Apologies for not catching the error in the original PR

@richardlau richardlau deleted the docs branch March 24, 2020 18:41
MylesBorins pushed a commit that referenced this pull request Mar 25, 2020
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: #32462
Refs: #31479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 25, 2020
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Apr 3, 2020
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: nodejs#32462
Refs: nodejs#31479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 3, 2020
Signed-off-by: Richard Lau <riclau@uk.ibm.com>

Backport-PR-URL: #32610
PR-URL: #32462
Refs: #31479
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@codebytere codebytere mentioned this pull request Apr 4, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants