stream: improve comments regarding end() errors. #32839
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up comments and TODOs and tries to provide a more detail description in regards to error behavior of end().
4 tasks
ronag
added
dont-land-on-v10.x
author ready
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30718/ (:heavy_check_mark:) |
addaleax
approved these changes
Apr 14, 2020
lpinca
approved these changes
Apr 14, 2020
jasnell
approved these changes
Apr 15, 2020
ronag
added a commit
that referenced
this pull request
Apr 16, 2020
Cleans up comments and TODOs and tries to provide a more detail description in regards to error behavior of end(). PR-URL: #32839 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 4a6a5c3 |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2020
Cleans up comments and TODOs and tries to provide a more detail description in regards to error behavior of end(). PR-URL: #32839 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up comments and TODOs and tries to provide a
more detail description in regards to error behavior
of end().
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes