Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: turn AllocatedBuffer into thin wrapper around v8::BackingStore #33381

Closed
wants to merge 1 commit into from
Closed

src: turn AllocatedBuffer into thin wrapper around v8::BackingStore #33381

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

With V8 8.3, the two APIs basically have feature parity, so
AllocatedBuffer can be turned into a wrapper around
v8::BackingStore.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels May 12, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/31301/

@addaleax addaleax added the blocked PRs that are blocked by other issues or PRs. label May 13, 2020
@addaleax
Copy link
Member Author

The CI failures should go away once #33321 lands. Until then, I’ve marked this as blocked.

@addaleax addaleax mentioned this pull request May 14, 2020
Closed
2 tasks
@addaleax
src: turn AllocatedBuffer into thin wrapper around v8::BackingStore
3ef0e38 
With V8 8.3, the two APIs basically have feature parity, so
`AllocatedBuffer` can be turned into a wrapper around
`v8::BackingStore`.
@addaleax addaleax force-pushed the allocated-buffer-backingstore branch from 58511a1 to 3ef0e38 Compare May 14, 2020 17:11
jasnell added a commit to jasnell/node that referenced this pull request May 14, 2020
@jasnell
src: turn AllocatedBuffer into thin wrapper around v8::BackingStore
c971497 
Alternative to nodejs#33381 that
reimplements that change on top of moving AllocatedBuffer out
of env.h
@addaleax addaleax removed the blocked PRs that are blocked by other issues or PRs. label May 16, 2020
@addaleax
Copy link
Member Author

I’ll close this as it’s included in #33291 now anyway.

@addaleax addaleax closed this May 16, 2020
@addaleax addaleax deleted the allocated-buffer-backingstore branch May 16, 2020 10:16
jasnell added a commit to jasnell/node that referenced this pull request May 30, 2020
@jasnell
src: turn AllocatedBuffer into thin wrapper around v8::BackingStore
9f8dc2f 
Alternative to nodejs#33381 that
reimplements that change on top of moving AllocatedBuffer out
of env.h
jasnell added a commit that referenced this pull request May 30, 2020
@jasnell
src: turn AllocatedBuffer into thin wrapper around v8::BackingStore
e2cd715 
Alternative to #33381 that
reimplements that change on top of moving AllocatedBuffer out
of env.h

PR-URL: #33291
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@jasnell @codebytere
src: turn AllocatedBuffer into thin wrapper around v8::BackingStore
27e9cb7 
Alternative to #33381 that
reimplements that change on top of moving AllocatedBuffer out
of env.h

PR-URL: #33291
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@jasnell @codebytere
src: turn AllocatedBuffer into thin wrapper around v8::BackingStore
ee6ec14 
Alternative to #33381 that
reimplements that change on top of moving AllocatedBuffer out
of env.h

PR-URL: #33291
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
@XadillaX XadillaX mentioned this pull request Apr 21, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addaleax @nodejs-github-bot