-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
win,fs: improve realpathSync performance #33941
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Moving knownHard object improves realpathSync perfomance. This results in require being 10% faster on Windows and realpathSync itself 50x faster. Ref: nodejs#28946
1 similar comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the correct solution to the performance problem as this will create a leak since knownHard
is never reset in this PR.
Additionally hard links may disappear during the lifetime of the process, giving incorrect results if |
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
Moving
knownHard
object improvesrealpathSync
perfomance.This results in require being 10% faster on Windows and
realpathSync
itself 50x faster.Ref: #28946
make -j4 test
(UNIX), orvcbuild test
(Windows) passes