[v12.x] src,doc,test: remove String::New default parameter #34357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kNormal` has been the implicit default for a while now (since V8 7.6). Refs: v8/v8@e0d7f81 PR-URL: nodejs#34248 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot
added
c++
|
Ah, this doesn’t apply on v12.x because of our ABI compat patches … well, nothing we can do in this case I think 🤷♀️ |
This was referenced Jul 15, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kNormalhas been the implicit default for a while now (since V8 7.6).Refs: v8/v8@e0d7f81
PR-URL: #34248
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl
Reviewed-By: Tobias Nießen tniessen@tnie.de
Reviewed-By: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes