Skip to content

build: fix test-ci-js task in Makefile #34433

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 0 commits into from
Jul 23, 2020
Merged

build: fix test-ci-js task in Makefile #34433

merged 0 commits into from
Jul 23, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 20, 2020

Move benchmark CI to native suite since it requires building an addon.

Refs: #34427 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the build Issues and PRs related to build files or the CI. label Jul 20, 2020
@Trott
Copy link
Member Author

Trott commented Jul 20, 2020

If someone could run vcbuild test-ci-js on Windows to see if this is a problem there or not, that would be helpful.

@bzoz
Copy link
Contributor

bzoz commented Jul 20, 2020

On Widows running vcbuild test-ci-js on master works, with one test failing (log here). I don't see it running benchmarks though, only JS tests

The failing test:

not ok 2796 abort/test-addon-uv-handle-leak
  ---
  duration_ms: 0.134
  severity: fail
  exitcode: 1
  stack: |-
    assert.js:385
        throw err;
        ^
    
    AssertionError [ERR_ASSERTION]: internal/modules/cjs/loader.js:1303
        at Object.<anonymous> (C:\Users\ja\Work\node\test\abort\test-addon-uv-handle-leak.js:93:9)
        at Module._compile (internal/modules/cjs/loader.js:1252:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:1273:10)
        at Module.load (internal/modules/cjs/loader.js:1101:32)
        at Function.Module._load (internal/modules/cjs/loader.js:966:14)
        at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:60:12)
        at internal/main/run_main_module.js:17:47 {
      generatedMessage: false,
      code: 'ERR_ASSERTION',
      actual: false,
      expected: true,
      operator: '=='
    }
  ...

@Trott Trott force-pushed the fix-make branch 2 times, most recently from 038c641 to debfdf1 Compare July 22, 2020 01:35
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 22, 2020

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 22, 2020
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Jul 23, 2020

Landed in 41c1e72

@Trott Trott closed this Jul 23, 2020
@Trott Trott merged commit 41c1e72 into nodejs:master Jul 23, 2020
@Trott Trott deleted the fix-make branch July 23, 2020 04:16
ruyadorno pushed a commit that referenced this pull request Jul 28, 2020
Move benchmark CI to native suite since it requires building an addon.

Refs: #34427 (comment)

PR-URL: #34433
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@ruyadorno ruyadorno mentioned this pull request Jul 28, 2020
ruyadorno pushed a commit that referenced this pull request Jul 28, 2020
Move benchmark CI to native suite since it requires building an addon.

Refs: #34427 (comment)

PR-URL: #34433
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
ruyadorno pushed a commit that referenced this pull request Jul 29, 2020
Move benchmark CI to native suite since it requires building an addon.

Refs: #34427 (comment)

PR-URL: #34433
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Move benchmark CI to native suite since it requires building an addon.

Refs: #34427 (comment)

PR-URL: #34433
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
Move benchmark CI to native suite since it requires building an addon.

Refs: #34427 (comment)

PR-URL: #34433
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@codebytere codebytere mentioned this pull request Sep 28, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants