Skip to content

[v12.x backport] doc: deprecate process.umask() with no arguments #34591

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[v12.x backport] doc: deprecate process.umask() with no arguments #34591

wants to merge 3 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 1, 2020

Node.js v12.x implements unflagged worker_threads, therefore process.umask() calls represent the same security risk as in Node.js v14.x.

Note that this PR does not backport the runtime deprecation.

Refs: #32321
Refs: #32499
Refs: #32711

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

cjihrig and others added 2 commits August 1, 2020 16:24
@cjihrig @aduh95
doc: deprecate process.umask() with no arguments
c21875b 
This commit introduces a documentation deprecation for calling
process.umask() with no arguments.

PR-URL: nodejs#32499
Fixes: nodejs#32321
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott @aduh95
doc: split process.umask() entry into two
0002ef9 
Split doc entries for process.umask() into one entry for process.umask()
(which is deprecated) and another for `process.umask(mask)` which is
not deprecated.

PR-URL: nodejs#32711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. v12.x labels Aug 1, 2020
aduh95
aduh95 commented Aug 1, 2020
View reviewed changes
aduh95
aduh95 commented Aug 1, 2020
View reviewed changes
@aduh95
Copy link
Contributor Author

aduh95 commented Aug 10, 2020

@cjihrig can you please review this?

@aduh95
Copy link
Contributor Author

aduh95 commented Aug 11, 2020

Based on #34592 (comment), this PR may be invalid. @targos what are your thoughts for this one?

MylesBorins pushed a commit that referenced this pull request Aug 18, 2020
@cjihrig @MylesBorins
doc: deprecate process.umask() with no arguments
b7fb94d 
This commit introduces a documentation deprecation for calling
process.umask() with no arguments.

Backport-PR-URL: #34591
PR-URL: #32499
Fixes: #32321
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Aug 18, 2020
@Trott @MylesBorins
doc: split process.umask() entry into two
bb0cc00 
Split doc entries for process.umask() into one entry for process.umask()
(which is deprecated) and another for `process.umask(mask)` which is
not deprecated.

Backport-PR-URL: #34591
PR-URL: #32711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

landed in 11a87ed...bb0cc00

@BethGriggs BethGriggs added the notable-change PRs with changes that should be highlighted in changelogs. label Sep 29, 2020
@aduh95 aduh95 deleted the backport-32499-to-erbium branch November 14, 2020 11:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mscdex mscdex mscdex left review comments

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. notable-change PRs with changes that should be highlighted in changelogs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @MylesBorins @mscdex @cjihrig @BethGriggs @nodejs-github-bot @Trott