Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: split test-crypto-dh-hash #34631

Closed
wants to merge 0 commits into from
Closed

test: split test-crypto-dh-hash #34631

wants to merge 0 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 5, 2020

test-crypto-dh-hash times out on some platforms. A single test case is
responsible for around 50% of the time to run, so split that test case
into its own file.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 5, 2020
@Trott
Copy link
Member Author

Trott commented Aug 5, 2020 •
edited by addaleax
Loading

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/15750/ (:green_heart:)

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 5, 2020
@addaleax addaleax added the review wanted PRs that need reviews. label Aug 8, 2020
@Trott
Copy link
Member Author

Trott commented Aug 11, 2020

Landed in bbfb014

Trott added a commit that referenced this pull request Aug 11, 2020
@Trott
test: split test-crypto-dh-hash
bbfb014 
test-crypto-dh-hash times out on some platforms. A single test case is
responsible for around 50% of the time to run, so split that test case
into its own file.

PR-URL: #34631
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott Trott closed this Aug 11, 2020
@Trott Trott deleted the crypto-split branch August 11, 2020 13:18
MylesBorins pushed a commit that referenced this pull request Aug 17, 2020
@Trott @MylesBorins
test: split test-crypto-dh-hash
742265d 
test-crypto-dh-hash times out on some platforms. A single test case is
responsible for around 50% of the time to run, so split that test case
into its own file.

PR-URL: #34631
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request Aug 20, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Aug 20, 2020
@Trott @BethGriggs
test: split test-crypto-dh-hash
fd5153c 
test-crypto-dh-hash times out on some platforms. A single test case is
responsible for around 50% of the time to run, so split that test case
into its own file.

PR-URL: #34631
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: split test-crypto-dh-hash
1078265 
test-crypto-dh-hash times out on some platforms. A single test case is
responsible for around 50% of the time to run, so split that test case
into its own file.

PR-URL: #34631
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: split test-crypto-dh-hash
b77309f 
test-crypto-dh-hash times out on some platforms. A single test case is
responsible for around 50% of the time to run, so split that test case
into its own file.

PR-URL: #34631
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
tniessen added a commit to tniessen/node that referenced this pull request Jul 18, 2022
@tniessen
test: merge test-crypto-dh-hash with modp18 test
ed86217 
This test file was split because it was taking a long time in some
versions of OpenSSL 1.1.1, but that is not the case anymore with
OpenSSL 3.0, so merge the tests again.

Refs: nodejs#34631
@tniessen tniessen mentioned this pull request Jul 18, 2022
Merged
tniessen added a commit to tniessen/node that referenced this pull request Jul 18, 2022
@tniessen
test: merge test-crypto-dh-hash with modp18 test
2b31af8 
This test file was split because it was taking a long time in some
versions of OpenSSL 1.1.1, but that is not the case anymore with
OpenSSL 3.0, so merge the tests again.

Refs: nodejs#34631
nodejs-github-bot pushed a commit that referenced this pull request Jul 22, 2022
@tniessen
test: merge test-crypto-dh-hash with modp18 test
373bbce 
This test file was split because it was taking a long time in some
versions of OpenSSL 1.1.1, but that is not the case anymore with
OpenSSL 3.0, so merge the tests again.

Refs: #34631

PR-URL: #43891
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jul 26, 2022
@tniessen @danielleadams
test: merge test-crypto-dh-hash with modp18 test
ef21ad2 
This test file was split because it was taking a long time in some
versions of OpenSSL 1.1.1, but that is not the case anymore with
OpenSSL 3.0, so merge the tests again.

Refs: #34631

PR-URL: #43891
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Fyko pushed a commit to Fyko/node that referenced this pull request Sep 15, 2022
@tniessen @Fyko
test: merge test-crypto-dh-hash with modp18 test
e5e1ee3 
This test file was split because it was taking a long time in some
versions of OpenSSL 1.1.1, but that is not the case anymore with
OpenSSL 3.0, so merge the tests again.

Refs: nodejs#34631

PR-URL: nodejs#43891
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @addaleax @targos @nodejs-github-bot