Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: move test-worker-init-failure to sequential #34740

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 11, 2020

(Includes the change in #34727 to avoid subsequent merge conflict. This supplants it.)

Unfortunately, the test is sensitive to resource constraints and is
unreliable on macOS in CI when in parallel.

Fixes: #34727

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Trott added 2 commits August 11, 2020 07:18
Let the check for the error code suffice and don't check for a
particular string in the message.

Fixes: nodejs#33759
Unfortunately, the test is sensitive to resource constraints and is
unreliable on macOS in CI when in parallel.

Fixes: nodejs#34727
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 11, 2020
@Trott
Copy link
Member Author

Trott commented Aug 11, 2020

Stress test that will hopefully show the issue on master: https://ci.nodejs.org/job/node-stress-single-test/165/
Stress test that will hopefully show the issue fixed with this PR: https://ci.nodejs.org/job/node-stress-single-test/166/

@addaleax
Copy link
Member

Do we know why the test is sensitive to resource constraints?

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2020
@Trott
Copy link
Member Author

Trott commented Aug 12, 2020

Do we know why the test is sensitive to resource constraints?

I'm guessing because it opens a lot of files (128).

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2020
@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member Author

Trott commented Aug 12, 2020

Do we know why the test is sensitive to resource constraints?

I'm guessing because it opens a lot of files (128).

An alternative we could experiment with is halving all the hard-coded numbers.

@gireeshpunathil
Copy link
Member

IMO the sensitivity to resource constraints is by de# the test, and it actually helped (and helps) to detect unforeseen control paths that are not covered in code and test, so is best placed to run in /parallel.

@Trott Trott closed this Aug 14, 2020
@Trott Trott deleted the work-ini-seq branch April 14, 2022 11:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants