Skip to content

test: improve pummel/test-timers.js #35175

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2020
Merged

test: improve pummel/test-timers.js #35175

merged 1 commit into from
Sep 15, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 13, 2020

  • use Date.now() instead of new Date() because only the timestamp is
    ever used, so we don't need the full Date object
  • use separate start times recorded for the two different test cases
  • improve assertion messages
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 13, 2020
@Trott
Copy link
Member Author

Trott commented Sep 13, 2020 •
edited
Loading

Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/16385/ ✅

@Trott
test: improve pummel/test-timers.js
ae257ca 
* use Date.now() instead of new Date() because only the timestamp is
  ever used, so we don't need the full Date object
* use separate start times recorded for the two different test cases
* improve assertion messages

PR-URL: nodejs#35175
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@Trott
Copy link
Member Author

Trott commented Sep 15, 2020

Landed in ae257ca

@Trott Trott merged commit ae257ca into nodejs:master Sep 15, 2020
@Trott Trott deleted the pummel-timers branch September 15, 2020 17:52
ruyadorno pushed a commit that referenced this pull request Sep 21, 2020
@Trott @ruyadorno
test: improve pummel/test-timers.js
49da459 
* use Date.now() instead of new Date() because only the timestamp is
  ever used, so we don't need the full Date object
* use separate start times recorded for the two different test cases
* improve assertion messages

PR-URL: #35175
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Sep 21, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@Trott @addaleax
test: improve pummel/test-timers.js
942551e 
* use Date.now() instead of new Date() because only the timestamp is
  ever used, so we don't need the full Date object
* use separate start times recorded for the two different test cases
* improve assertion messages

PR-URL: #35175
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@Trott @joesepi
test: improve pummel/test-timers.js
5e7d01d 
* use Date.now() instead of new Date() because only the timestamp is
  ever used, so we don't need the full Date object
* use separate start times recorded for the two different test cases
* improve assertion messages

PR-URL: nodejs#35175
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@Leko Leko Leko approved these changes

@watilde watilde watilde approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @addaleax @Leko @watilde @nodejs-github-bot