Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[v10.x] src: allows escaping NODE_OPTIONS with backslashes #35342

Closed
wants to merge 2 commits into from
Closed

[v10.x] src: allows escaping NODE_OPTIONS with backslashes #35342

wants to merge 2 commits into from

Conversation

rickyes
Copy link
Contributor

@rickyes rickyes commented Sep 25, 2020 •
edited
Loading

The characters specified within NODE_OPTIONS can now be escaped, which
is handy especially in conjunction with --require (where the file path
might happen to contain spaces that shouldn't cause the option to be
split into two).

This PR adds v10.x-compatible commits in addition to backport of #24065.

Fixes: #12971
Refs: microsoft/vscode-js-debug#769
PR-URL: #24065
Reviewed-By: @addaleax

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Maël Nison and others added 2 commits September 25, 2020 20:51
@rickyes
src: allows escaping NODE_OPTIONS with backslashes
a2e42eb 
The characters specified within NODE_OPTIONS can now be escaped, which
is handy especially in conjunction with `--require` (where the file path
might happen to contain spaces that shouldn't cause the option to be
split into two).

Fixes: nodejs#12971

PR-URL: nodejs#24065
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@rickyes
fixup! allows escaping NODE_OPTIONS with backslashes
c7e1356
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v10.x labels Sep 25, 2020
@rickyes
Copy link
Contributor Author

rickyes commented Sep 25, 2020

/cc @atian25

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33239/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33242/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 25, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33245/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33247/

@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 26, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33250/

@rickyes rickyes requested a review from addaleax September 27, 2020 03:10
@rickyes rickyes added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 27, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33261/

@rickyes
Copy link
Contributor Author

rickyes commented Sep 27, 2020

There are a lot of flaky tests that don't seem to be relevant to this PR, @addaleax @BridgeAR PTAL

@MylesBorins
Copy link
Contributor

Ping @nodejs/LTS

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Sep 27, 2020 •
edited by rickyes
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33265/ 💛

@rickyes rickyes mentioned this pull request Sep 28, 2020
Closed
4 tasks
richardlau pushed a commit that referenced this pull request Oct 7, 2020
@richardlau
src: allows escaping NODE_OPTIONS with backslashes
2eb6273 
The characters specified within NODE_OPTIONS can now be escaped, which
is handy especially in conjunction with `--require` (where the file path
might happen to contain spaces that shouldn't cause the option to be
split into two).

Fixes: #12971

PR-URL: #24065
Backport-PR-URL: #35342
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Refs: microsoft/vscode-js-debug#769
@richardlau
Copy link
Member

Landed in 2eb6273.

@richardlau richardlau closed this Oct 7, 2020
@rickyes rickyes deleted the backport-24065-to-v10.x branch October 10, 2020 04:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@addaleax addaleax Awaiting requested review from addaleax

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickyes @nodejs-github-bot @MylesBorins @richardlau