Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

net: refactor to use more primordials #36303

Closed
wants to merge 4 commits into from
Closed

net: refactor to use more primordials #36303

wants to merge 4 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 28, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Nov 28, 2020
@aduh95 aduh95 added the needs-benchmark-ci PR that need a benchmark CI run. label Nov 28, 2020
@Trott
Copy link
Member

Trott commented Nov 30, 2020

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/734/

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34635/

@aduh95
Copy link
Contributor Author

aduh95 commented Dec 1, 2020 •
edited
Loading

Benchmark results look promising overall:

                                                                                              confidence improvement accuracy (*)    (**)    (***)
net/net-c2s.js dur=5 type='buf' len=102400                                                            **     21.53 %      ±15.97% ±21.30%  ±27.81%
net/net-c2s.js dur=5 type='buf' len=16777216                                                           *     20.71 %      ±16.05% ±21.40%  ±27.95%
net/net-c2s.js dur=5 type='utf' len=16777216                                                           *     -5.12 %       ±4.84%  ±6.46%   ±8.44%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='buf' sendchunklen=131072                 **     30.52 %      ±18.87% ±25.11%  ±32.69%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='buf' sendchunklen=32768                   *     25.63 %      ±22.90% ±30.49%  ±39.72%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='utf' sendchunklen=16777216                *      5.74 %       ±4.92%  ±6.57%   ±8.58%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='utf' sendchunklen=32768               *     -1.62 %       ±1.43%  ±1.91%   ±2.51%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='asc' sendchunklen=16777216                **      7.34 %       ±5.16%  ±6.86%   ±8.94%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='buf' sendchunklen=32768                    *     26.38 %      ±23.11% ±30.76%  ±40.05%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='buf' sendchunklen=131072            **      3.01 %       ±2.08%  ±2.77%   ±3.61%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='asc' sendchunklen=16777216            **     -7.27 %       ±4.39%  ±5.84%   ±7.60%
net/net-wrap-js-stream-passthrough.js dur=5 type='asc' len=102400                                    ***     37.37 %      ±19.53% ±26.19%  ±34.51%
net/tcp-raw-pipe.js dur=5 type='utf' len=102400                                                        *     20.97 %      ±16.67% ±22.18%  ±28.87%
net/tcp-raw-s2c.js dur=5 type='asc' len=102400                                                         *     15.02 %      ±12.45% ±16.57%  ±21.57%

                                                                                              confidence improvement accuracy (*)    (**)    (***)
net/net-c2s-cork.js dur=5 type='buf' len=1024                                                                -1.88 %      ±20.98% ±27.91%  ±36.33%
net/net-c2s-cork.js dur=5 type='buf' len=128                                                                 -0.92 %       ±8.32% ±11.08%  ±14.44%
net/net-c2s-cork.js dur=5 type='buf' len=16                                                                  -1.97 %       ±4.76%  ±6.34%   ±8.25%
net/net-c2s-cork.js dur=5 type='buf' len=32                                                                  -1.62 %       ±6.14%  ±8.17%  ±10.64%
net/net-c2s-cork.js dur=5 type='buf' len=4                                                                   -0.40 %       ±1.89%  ±2.52%   ±3.28%
net/net-c2s-cork.js dur=5 type='buf' len=512                                                                -10.36 %      ±13.95% ±18.55%  ±24.15%
net/net-c2s-cork.js dur=5 type='buf' len=64                                                                  -1.31 %       ±6.15%  ±8.19%  ±10.67%
net/net-c2s-cork.js dur=5 type='buf' len=8                                                                   -3.41 %       ±4.77%  ±6.35%   ±8.27%
net/net-c2s.js dur=5 type='asc' len=102400                                                                    2.55 %      ±12.14% ±16.17%  ±21.07%
net/net-c2s.js dur=5 type='asc' len=16777216                                                                  1.83 %       ±8.93% ±11.90%  ±15.53%
net/net-c2s.js dur=5 type='asc' len=64                                                                        1.62 %       ±8.99% ±11.97%  ±15.58%
net/net-c2s.js dur=5 type='buf' len=102400                                                            **     21.53 %      ±15.97% ±21.30%  ±27.81%
net/net-c2s.js dur=5 type='buf' len=16777216                                                           *     20.71 %      ±16.05% ±21.40%  ±27.95%
net/net-c2s.js dur=5 type='buf' len=64                                                                        2.88 %       ±8.24% ±10.96%  ±14.27%
net/net-c2s.js dur=5 type='utf' len=102400                                                                    4.08 %      ±12.50% ±16.64%  ±21.66%
net/net-c2s.js dur=5 type='utf' len=16777216                                                           *     -5.12 %       ±4.84%  ±6.46%   ±8.44%
net/net-c2s.js dur=5 type='utf' len=64                                                                        1.93 %       ±6.08%  ±8.10%  ±10.55%
net/net-pipe.js dur=5 type='asc' len=102400                                                                   0.49 %      ±12.95% ±17.23%  ±22.42%
net/net-pipe.js dur=5 type='asc' len=16777216                                                                -5.01 %       ±7.14%  ±9.50%  ±12.37%
net/net-pipe.js dur=5 type='asc' len=2                                                                        0.07 %       ±3.06%  ±4.08%   ±5.32%
net/net-pipe.js dur=5 type='asc' len=64                                                                      -5.40 %       ±9.36% ±12.45%  ±16.21%
net/net-pipe.js dur=5 type='buf' len=102400                                                                  -5.63 %      ±12.57% ±16.72%  ±21.76%
net/net-pipe.js dur=5 type='buf' len=16777216                                                                -3.65 %       ±9.45% ±12.58%  ±16.37%
net/net-pipe.js dur=5 type='buf' len=2                                                                        2.78 %       ±3.05%  ±4.06%   ±5.29%
net/net-pipe.js dur=5 type='buf' len=64                                                                       1.21 %      ±11.43% ±15.21%  ±19.79%
net/net-pipe.js dur=5 type='utf' len=102400                                                                  10.13 %      ±16.57% ±22.05%  ±28.70%
net/net-pipe.js dur=5 type='utf' len=16777216                                                                 3.46 %       ±4.81%  ±6.40%   ±8.34%
net/net-pipe.js dur=5 type='utf' len=2                                                                       -1.36 %       ±2.89%  ±3.85%   ±5.01%
net/net-pipe.js dur=5 type='utf' len=64                                                                      -3.42 %       ±5.64%  ±7.51%   ±9.78%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='asc' sendchunklen=131072                         3.81 %      ±15.39% ±20.48%  ±26.66%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='asc' sendchunklen=16777216                       1.97 %       ±6.84%  ±9.10%  ±11.86%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='asc' sendchunklen=256                            1.67 %       ±8.19% ±10.90%  ±14.19%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='asc' sendchunklen=32768                         -3.58 %      ±19.01% ±25.29%  ±32.93%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='buf' sendchunklen=131072                 **     30.52 %      ±18.87% ±25.11%  ±32.69%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='buf' sendchunklen=16777216                      -1.88 %      ±15.85% ±21.09%  ±27.45%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='buf' sendchunklen=256                            2.95 %      ±12.40% ±16.50%  ±21.48%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='buf' sendchunklen=32768                   *     25.63 %      ±22.90% ±30.49%  ±39.72%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='utf' sendchunklen=131072                         0.29 %      ±17.53% ±23.33%  ±30.37%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='utf' sendchunklen=16777216                *      5.74 %       ±4.92%  ±6.57%   ±8.58%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='utf' sendchunklen=256                           -6.86 %       ±8.93% ±11.88%  ±15.46%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=0 type='utf' sendchunklen=32768                          8.12 %      ±20.32% ±27.04%  ±35.20%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='asc' sendchunklen=131072                  -1.45 %       ±1.91%  ±2.54%   ±3.31%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='asc' sendchunklen=16777216                 1.51 %       ±4.26%  ±5.67%   ±7.38%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='asc' sendchunklen=256                      1.24 %       ±2.91%  ±3.87%   ±5.04%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='asc' sendchunklen=32768                   -0.80 %       ±2.33%  ±3.10%   ±4.04%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='buf' sendchunklen=131072                   1.93 %       ±2.37%  ±3.16%   ±4.11%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='buf' sendchunklen=16777216                 1.56 %       ±2.12%  ±2.81%   ±3.66%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='buf' sendchunklen=256                      0.21 %       ±1.51%  ±2.01%   ±2.62%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='buf' sendchunklen=32768                   -0.64 %       ±2.22%  ±2.96%   ±3.85%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='utf' sendchunklen=131072                  -0.75 %       ±2.19%  ±2.91%   ±3.78%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='utf' sendchunklen=16777216                 1.65 %       ±2.12%  ±2.82%   ±3.67%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='utf' sendchunklen=256                     -0.17 %       ±2.70%  ±3.60%   ±4.70%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=1048576 type='utf' sendchunklen=32768                    0.70 %       ±1.04%  ±1.38%   ±1.80%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='asc' sendchunklen=131072                     0.07 %       ±2.14%  ±2.85%   ±3.71%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='asc' sendchunklen=16777216                  -2.27 %       ±3.87%  ±5.15%   ±6.71%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='asc' sendchunklen=256                        1.94 %       ±3.13%  ±4.17%   ±5.43%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='asc' sendchunklen=32768                      1.25 %       ±2.13%  ±2.84%   ±3.70%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='buf' sendchunklen=131072                     1.32 %       ±2.12%  ±2.82%   ±3.67%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='buf' sendchunklen=16777216                  -0.24 %       ±1.70%  ±2.27%   ±2.95%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='buf' sendchunklen=256                       -0.90 %       ±2.27%  ±3.02%   ±3.94%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='buf' sendchunklen=32768                     -0.21 %       ±2.06%  ±2.74%   ±3.56%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='utf' sendchunklen=131072                    -0.71 %       ±1.78%  ±2.37%   ±3.08%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='utf' sendchunklen=16777216                   1.38 %       ±2.26%  ±3.01%   ±3.92%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='utf' sendchunklen=256                       -2.83 %       ±4.14%  ±5.52%   ±7.19%
net/net-s2c.js dur=5 recvbufgenfn='false' recvbuflen=65536 type='utf' sendchunklen=32768               *     -1.62 %       ±1.43%  ±1.91%   ±2.51%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='asc' sendchunklen=131072                         -8.35 %      ±16.27% ±21.66%  ±28.20%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='asc' sendchunklen=16777216                **      7.34 %       ±5.16%  ±6.86%   ±8.94%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='asc' sendchunklen=256                             0.31 %       ±9.68% ±12.88%  ±16.76%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='asc' sendchunklen=32768                           1.05 %      ±16.31% ±21.72%  ±28.30%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='buf' sendchunklen=131072                          8.32 %      ±20.62% ±27.45%  ±35.76%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='buf' sendchunklen=16777216                       -4.50 %      ±16.07% ±21.39%  ±27.83%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='buf' sendchunklen=256                             7.65 %      ±12.50% ±16.64%  ±21.65%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='buf' sendchunklen=32768                    *     26.38 %      ±23.11% ±30.76%  ±40.05%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='utf' sendchunklen=131072                          4.45 %      ±18.53% ±24.65%  ±32.09%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='utf' sendchunklen=16777216                       -0.05 %       ±5.01%  ±6.67%   ±8.68%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='utf' sendchunklen=256                            -1.83 %      ±10.53% ±14.01%  ±18.25%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=0 type='utf' sendchunklen=32768                          -5.28 %      ±18.62% ±24.78%  ±32.26%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='asc' sendchunklen=131072                    0.70 %       ±2.44%  ±3.25%   ±4.23%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='asc' sendchunklen=16777216                  1.03 %       ±4.49%  ±5.98%   ±7.78%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='asc' sendchunklen=256                      -2.28 %       ±2.50%  ±3.33%   ±4.36%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='asc' sendchunklen=32768                     0.17 %       ±2.04%  ±2.71%   ±3.53%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='buf' sendchunklen=131072            **      3.01 %       ±2.08%  ±2.77%   ±3.61%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='buf' sendchunklen=16777216                 -0.41 %       ±2.64%  ±3.51%   ±4.57%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='buf' sendchunklen=256                       0.22 %       ±1.91%  ±2.55%   ±3.34%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='buf' sendchunklen=32768                    -0.41 %       ±2.08%  ±2.77%   ±3.61%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='utf' sendchunklen=131072                   -0.22 %       ±1.77%  ±2.35%   ±3.07%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='utf' sendchunklen=16777216                 -0.36 %       ±1.80%  ±2.40%   ±3.12%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='utf' sendchunklen=256                      -0.25 %       ±3.91%  ±5.21%   ±6.79%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=1048576 type='utf' sendchunklen=32768                    -0.78 %       ±1.34%  ±1.78%   ±2.32%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='asc' sendchunklen=131072                     -1.16 %       ±2.41%  ±3.21%   ±4.18%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='asc' sendchunklen=16777216            **     -7.27 %       ±4.39%  ±5.84%   ±7.60%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='asc' sendchunklen=256                         2.19 %       ±3.16%  ±4.21%   ±5.49%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='asc' sendchunklen=32768                       0.92 %       ±2.14%  ±2.84%   ±3.70%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='buf' sendchunklen=131072                     -0.84 %       ±2.24%  ±2.98%   ±3.89%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='buf' sendchunklen=16777216                   -0.01 %       ±2.15%  ±2.86%   ±3.72%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='buf' sendchunklen=256                         0.44 %       ±2.53%  ±3.37%   ±4.38%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='buf' sendchunklen=32768                      -1.15 %       ±1.97%  ±2.62%   ±3.41%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='utf' sendchunklen=131072                      1.01 %       ±2.22%  ±2.97%   ±3.90%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='utf' sendchunklen=16777216                    0.23 %       ±3.10%  ±4.12%   ±5.37%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='utf' sendchunklen=256                        -2.57 %       ±3.06%  ±4.07%   ±5.30%
net/net-s2c.js dur=5 recvbufgenfn='true' recvbuflen=65536 type='utf' sendchunklen=32768                      -0.54 %       ±1.00%  ±1.33%   ±1.74%
net/net-wrap-js-stream-passthrough.js dur=5 type='asc' len=102400                                    ***     37.37 %      ±19.53% ±26.19%  ±34.51%
net/net-wrap-js-stream-passthrough.js dur=5 type='asc' len=16777216                                           0.64 %      ±31.62% ±42.07%  ±54.76%
net/net-wrap-js-stream-passthrough.js dur=5 type='asc' len=64                                                -2.78 %       ±3.84%  ±5.11%   ±6.65%
net/net-wrap-js-stream-passthrough.js dur=5 type='buf' len=102400                                            -5.75 %      ±13.56% ±18.04%  ±23.48%
net/net-wrap-js-stream-passthrough.js dur=5 type='buf' len=16777216                                          -4.09 %       ±9.10% ±12.11%  ±15.76%
net/net-wrap-js-stream-passthrough.js dur=5 type='buf' len=64                                                 0.77 %       ±3.17%  ±4.22%   ±5.50%
net/net-wrap-js-stream-passthrough.js dur=5 type='utf' len=102400                                           -14.13 %      ±19.50% ±25.94%  ±33.77%
net/net-wrap-js-stream-passthrough.js dur=5 type='utf' len=16777216                                           7.47 %       ±9.56% ±12.72%  ±16.57%
net/net-wrap-js-stream-passthrough.js dur=5 type='utf' len=64                                                 1.39 %       ±4.69%  ±6.25%   ±8.16%
net/tcp-raw-c2s.js dur=5 type='asc' len=102400                                                               -3.12 %       ±6.90%  ±9.19%  ±11.96%
net/tcp-raw-c2s.js dur=5 type='asc' len=16777216                                                             -1.41 %       ±4.40%  ±5.86%   ±7.65%
net/tcp-raw-c2s.js dur=5 type='buf' len=102400                                                               -3.29 %       ±9.58% ±12.76%  ±16.62%
net/tcp-raw-c2s.js dur=5 type='buf' len=16777216                                                             -3.04 %       ±7.92% ±10.55%  ±13.73%
net/tcp-raw-c2s.js dur=5 type='utf' len=102400                                                               -1.12 %       ±3.56%  ±4.73%   ±6.17%
net/tcp-raw-c2s.js dur=5 type='utf' len=16777216                                                              0.40 %       ±2.54%  ±3.38%   ±4.40%
net/tcp-raw-pipe.js dur=5 type='asc' len=102400                                                               3.16 %       ±9.53% ±12.68%  ±16.50%
net/tcp-raw-pipe.js dur=5 type='asc' len=16777216                                                             0.20 %      ±22.84% ±30.39%  ±39.56%
net/tcp-raw-pipe.js dur=5 type='buf' len=102400                                                               5.16 %      ±14.97% ±19.92%  ±25.92%
net/tcp-raw-pipe.js dur=5 type='buf' len=16777216                                                            30.74 %      ±62.96% ±83.85% ±109.30%
net/tcp-raw-pipe.js dur=5 type='utf' len=102400                                                        *     20.97 %      ±16.67% ±22.18%  ±28.87%
net/tcp-raw-pipe.js dur=5 type='utf' len=16777216                                                            -7.51 %       ±8.40% ±11.18%  ±14.56%
net/tcp-raw-s2c.js dur=5 type='asc' len=102400                                                         *     15.02 %      ±12.45% ±16.57%  ±21.57%
net/tcp-raw-s2c.js dur=5 type='asc' len=16777216                                                             -3.68 %       ±6.40%  ±8.52%  ±11.09%
net/tcp-raw-s2c.js dur=5 type='buf' len=102400                                                                6.28 %      ±12.64% ±16.83%  ±21.93%
net/tcp-raw-s2c.js dur=5 type='buf' len=16777216                                                             -0.78 %       ±7.77% ±10.34%  ±13.45%
net/tcp-raw-s2c.js dur=5 type='utf' len=102400                                                                0.82 %      ±10.90% ±14.50%  ±18.87%
net/tcp-raw-s2c.js dur=5 type='utf' len=16777216                                                             -2.18 %       ±3.63%  ±4.86%   ±6.41%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case there are 128 comparisons, you can thus
expect the following amount of false-positive results:
 6.40 false positives, when considering a   5% risk acceptance (*, **, ***),
 1.28 false positives, when considering a   1% risk acceptance (**, ***),
 0.13 false positives, when considering a 0.1% risk acceptance (***)

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34651/

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-benchmark-ci PR that need a benchmark CI run. labels Dec 1, 2020
jasnell pushed a commit that referenced this pull request Dec 7, 2020
@aduh95 @jasnell
net: refactor to use more primordials
0869b82 
PR-URL: #36303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Dec 7, 2020

Landed in 0869b82

@jasnell jasnell closed this Dec 7, 2020
@aduh95 aduh95 deleted the net-primordials branch December 7, 2020 18:09
danielleadams pushed a commit that referenced this pull request Dec 7, 2020
@aduh95 @danielleadams
net: refactor to use more primordials
8611b8f 
PR-URL: #36303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
Merged
cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 8, 2020
@aduh95 @cjihrig
net: refactor to use more primordials
2d0243a 
PR-URL: nodejs#36303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 16, 2021
@aduh95 @targos
net: refactor to use more primordials
5c7779d 
PR-URL: #36303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
net: refactor to use more primordials
52cbe89 
PR-URL: #36303
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @Trott @nodejs-github-bot @jasnell