Skip to content

test: remove test-http2-client-upload as flaky #36496

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

test: remove test-http2-client-upload as flaky #36496

merged 1 commit into from
Dec 15, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 12, 2020

The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.

Refs: #29889

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 12, 2020
@targos targos added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 13, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 13, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34920/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34931/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34934/

@Trott
test: remove test-http2-client-upload as flaky
7c80817 
The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.

Refs: nodejs#29889

PR-URL: nodejs#36496
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Dec 15, 2020

Landed in 7c80817

@Trott Trott merged commit 7c80817 into nodejs:master Dec 15, 2020
@Trott Trott deleted the flaky-removal branch December 15, 2020 11:41
targos pushed a commit that referenced this pull request Dec 21, 2020
@Trott @targos
test: remove test-http2-client-upload as flaky
9f2d3c2 
The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.

Refs: #29889

PR-URL: #36496
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Dec 22, 2020
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: remove test-http2-client-upload as flaky
c0604c9 
The test has not failed in quite some time (as far as I can tell) on CI.
Optimistically removing it.

Refs: #29889

PR-URL: #36496
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@Flarna Flarna Flarna approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @lpinca @targos @Flarna