Skip to content

lib: remove dead code from internal/http.js #36630

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 27, 2020
Merged

lib: remove dead code from internal/http.js #36630

merged 1 commit into from
Dec 27, 2020

Conversation

Lxxyx
Copy link
Member

@Lxxyx Lxxyx commented Dec 25, 2020

The nowDate function is no longer used, but the code is not removed.
Refs: #32329

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Dec 25, 2020
@benjamingr benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 25, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35079/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 26, 2020
@Lxxyx @Trott
http: remove dead code from internal/http.js
acaa58e 
PR-URL: nodejs#36630
Refs: nodejs#32329
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott force-pushed the remove-internal-http-deadcode branch from 8cf00b9 to acaa58e Compare December 27, 2020 14:58
@Trott
Copy link
Member

Trott commented Dec 27, 2020

Landed in acaa58e

@Trott Trott merged commit acaa58e into nodejs:master Dec 27, 2020
@Lxxyx Lxxyx deleted the remove-internal-http-deadcode branch December 27, 2020 15:00
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@Lxxyx @danielleadams
http: remove dead code from internal/http.js
9156f43 
PR-URL: #36630
Refs: #32329
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
@aduh95 aduh95 mentioned this pull request Jan 12, 2021
Closed
aduh95 pushed a commit to aduh95/node that referenced this pull request Jan 13, 2021
@Lxxyx @aduh95
http: remove dead code from internal/http.js
bae71f0 
PR-URL: nodejs#36630
Refs: nodejs#32329
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 13, 2021
@Lxxyx @danielleadams
http: remove dead code from internal/http.js
d858c95 
PR-URL: #36630
Backport-PR-URL: #36890
Refs: #32329
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 1, 2021
@Lxxyx @targos
http: remove dead code from internal/http.js
8163f31 
PR-URL: #36630
Refs: #32329
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Lxxyx @nodejs-github-bot @Trott @addaleax @benjamingr @lpinca @aduh95