Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

wasi: refactor to avoid unsafe array iteration #36724

Merged
merged 1 commit into from
Jan 6, 2021
Merged

wasi: refactor to avoid unsafe array iteration #36724

merged 1 commit into from
Jan 6, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 1, 2021

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the wasi Issues and PRs related to the WebAssembly System Interface. label Jan 1, 2021
Trott
Trott approved these changes Jan 2, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be telling you something you already know, but in the past, we've used for rather than .forEach() for performance purposes. I don't think either of these are hot paths, so it's probably fine. @nodejs/wasi

@aduh95
Copy link
Contributor Author

aduh95 commented Jan 2, 2021

I might be telling you something you already know, but in the past, we've used for rather than .forEach() for performance purposes. I don't think either of these are hot paths, so it's probably fine.

I'm running benchmarks on my other PRs with changes similar to this one, so far I haven't hit an perf issue. My guess is that both approaches are equivalent, but we can use a for(;;) loop instead if we find out that .forEach() is less efficient.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 3, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 3, 2021
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35295/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2021
@aduh95
wasi: refactor to avoid unsafe array iteration
08d8958 
PR-URL: nodejs#36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 force-pushed the wasi-array-iteration branch from f553c8e to 08d8958 Compare January 6, 2021 10:34
@aduh95
Copy link
Contributor Author

aduh95 commented Jan 6, 2021

Landed in 08d8958

@aduh95 aduh95 merged commit 08d8958 into nodejs:master Jan 6, 2021
@aduh95 aduh95 deleted the wasi-array-iteration branch January 6, 2021 10:34
danielleadams pushed a commit that referenced this pull request Jan 12, 2021
@aduh95 @danielleadams
wasi: refactor to avoid unsafe array iteration
d5a9799 
PR-URL: #36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Jan 12, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@aduh95 @targos
wasi: refactor to avoid unsafe array iteration
de1c976 
PR-URL: #36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
wasi: refactor to avoid unsafe array iteration
b99ff61 
PR-URL: #36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
wasi: refactor to avoid unsafe array iteration
0dea866 
PR-URL: #36724
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @jasnell @Trott