Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN #36937

Closed
wants to merge 1 commit into from
Closed

perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN #36937

wants to merge 1 commit into from

Conversation

Lxxyx
Copy link
Member

@Lxxyx Lxxyx commented Jan 15, 2021

Fixes: #36936

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 15, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35561/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35599/

@jasnell
Copy link
Member

jasnell commented Jan 18, 2021

Landed in 59af4e6

@jasnell jasnell closed this Jan 18, 2021
jasnell pushed a commit that referenced this pull request Jan 18, 2021
@Lxxyx @jasnell
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
59af4e6 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Lxxyx Lxxyx deleted the fix-perf_hooks-histogram-error branch January 18, 2021 21:43
ruyadorno pushed a commit that referenced this pull request Jan 22, 2021
@Lxxyx @ruyadorno
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
327a2b7 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Jan 22, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Jan 25, 2021
@Lxxyx @ruyadorno
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
3f75a60 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 25, 2021
@Lxxyx @targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
579d199 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
@Lxxyx @targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
bd298f7 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@Lxxyx @targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
38178b8 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@Lxxyx @targos
perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param…
726ef40 
… is NaN

Fixes: #36936

PR-URL: #36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

perf_hooks: histogram.percentile throw Assertion `(percentile) > (0)' failed when param is NaN
6 participants
@Lxxyx @nodejs-github-bot @jasnell @cjihrig @aduh95 @RaisinTen