Skip to content

doc: mention adding Fixes to collaborator onboarding PR #37097

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Also update the example to include the Fixes url.

Also update the example to include the Fixes url.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jan 27, 2021
@Lxxyx Lxxyx added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2021
@nodejs-github-bot
Copy link
Collaborator

@Lxxyx Lxxyx added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 27, 2021
@Lxxyx
Copy link
Member

Lxxyx commented Jan 27, 2021

fast track?

Lxxyx pushed a commit that referenced this pull request Jan 27, 2021
Also update the example to include the Fixes url.

PR-URL: #37097
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@Lxxyx
Copy link
Member

Lxxyx commented Jan 27, 2021

Landed in 35fe310

@Lxxyx Lxxyx closed this Jan 27, 2021
targos pushed a commit that referenced this pull request Feb 2, 2021
Also update the example to include the Fixes url.

PR-URL: #37097
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@targos targos mentioned this pull request Feb 2, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Also update the example to include the Fixes url.

PR-URL: #37097
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants