Skip to content

src: use make_shared for safe allocation #37139

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2021
Merged

src: use make_shared for safe allocation #37139

merged 1 commit into from
Feb 6, 2021

Conversation

yashLadha
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 30, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35850/

@yashLadha
Copy link
Contributor Author

Can I go ahead and deploy @addaleax @jasnell @cjihrig?

@Trott Trott force-pushed the fix_reduce_allocation branch from 0c80e8c to f3381a2 Compare February 6, 2021 17:02
Trott pushed a commit to yashLadha/node that referenced this pull request Feb 6, 2021
@yashLadha @Trott
src: use make_shared for safe allocation
f3381a2 
Using the reset does a double allocation and is error prone if some
exception occured which is very unlikely but can happen. make_shared_ptr
gives hedge over this and handle the failure in allocation.

PR-URL: nodejs#37139
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@yashLadha @Trott
src: use make_shared for safe allocation
36cc0ee 
Using the reset does a double allocation and is error prone if some
exception occured which is very unlikely but can happen. make_shared_ptr
gives hedge over this and handle the failure in allocation.

PR-URL: nodejs#37139
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott Trott force-pushed the fix_reduce_allocation branch from f3381a2 to 36cc0ee Compare February 6, 2021 17:03
@Trott Trott merged commit 36cc0ee into nodejs:master Feb 6, 2021
@Trott
Copy link
Member

Trott commented Feb 6, 2021

Landed in 36cc0ee

danielleadams pushed a commit that referenced this pull request Feb 16, 2021
@yashLadha @danielleadams
src: use make_shared for safe allocation
354df9e 
Using the reset does a double allocation and is error prone if some
exception occured which is very unlikely but can happen. make_shared_ptr
gives hedge over this and handle the failure in allocation.

PR-URL: #37139
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This was referenced Feb 16, 2021
Closed
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@yashLadha @targos
src: use make_shared for safe allocation
88d9676 
Using the reset does a double allocation and is error prone if some
exception occured which is very unlikely but can happen. make_shared_ptr
gives hedge over this and handle the failure in allocation.

PR-URL: #37139
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yashLadha @nodejs-github-bot @Trott @jasnell @addaleax @cjihrig