Skip to content

doc: fix pr-url for DEP0148 #37205

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 3, 2021

Was pointing to #35746 instead of #35747.

@aduh95 aduh95 added doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 3, 2021
@nodejs-github-bot nodejs-github-bot added the deprecations Issues and PRs related to deprecations. label Feb 3, 2021
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 3, 2021

fast-track?

PR-URL: nodejs#37205
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 force-pushed the fix-pr-url-DEP0148 branch from cb9d544 to b586c6a Compare February 3, 2021 14:53
@aduh95
Copy link
Contributor Author

aduh95 commented Feb 3, 2021

Landed in b586c6a

@aduh95 aduh95 closed this Feb 3, 2021
@aduh95 aduh95 merged commit b586c6a into nodejs:master Feb 3, 2021
@aduh95 aduh95 deleted the fix-pr-url-DEP0148 branch February 3, 2021 14:54
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
PR-URL: #37205
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Feb 16, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants