Skip to content

doc: document that NODE_EXTRA_CA_CERTS is read only once #37562

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: document that NODE_EXTRA_CA_CERTS is read only once #37562

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 1, 2021

Fixes: #20432

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 1, 2021
mhdawson
mhdawson approved these changes Mar 1, 2021
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as documenting current behavior

@jasnell
Copy link
Member Author

jasnell commented Mar 5, 2021

Landed in 9c1274a

@jasnell jasnell closed this Mar 5, 2021
jasnell added a commit that referenced this pull request Mar 5, 2021
@jasnell
doc: document that NODE_EXTRA_CA_CERTS is read only once
9c1274a 
Fixes: #20432

PR-URL: #37562
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@jasnell @danielleadams
doc: document that NODE_EXTRA_CA_CERTS is read only once
267bbe3 
Fixes: #20432

PR-URL: #37562
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@jasnell @targos
doc: document that NODE_EXTRA_CA_CERTS is read only once
c21731b 
Fixes: #20432

PR-URL: #37562
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NODE_EXTRA_CA_CERTS cannot be set in code or relative
5 participants
@jasnell @lpinca @richardlau @mhdawson @nodejs-github-bot