Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: fix flaky test-hash-seed #38059

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 3, 2021

This test can take a long time to run. Some of our CI hosts are configured
to consider the task stalled if there is no output for 3 minutes. TO
prevent that from canceling this test and the entire test suite, output
something every 60 seconds or so.

Refs: #34289

This test can take a long time to run. Some of our CI hosts are configured
to consider the task stalled if there is no output for 3 minutes. TO
prevent that from canceling this test and the entire test suite, output
something every 60 seconds or so.

Refs: nodejs#34289
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 3, 2021
@Trott Trott added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Apr 3, 2021
@Trott
Copy link
Member Author

Trott commented Apr 3, 2021

@Trott Trott mentioned this pull request Apr 3, 2021
2 tasks
@Trott
Copy link
Member Author

Trott commented Apr 3, 2021

Alas, this doesn't fix it on CI because the console.log() doesn't show up because tools/test.py consumes it. We'll have to extend the timeout (in Jenkins, I think--this isn't the usual test.py timeout) or find some other way.

@Trott Trott closed this Apr 3, 2021
@Trott Trott deleted the fix-test-hash-seed branch September 25, 2022 17:08
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants