Skip to content

tools: update ESLint to 7.24.0 #38179

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2021
Merged

tools: update ESLint to 7.24.0 #38179

merged 1 commit into from
Apr 12, 2021

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Apr 9, 2021

Update ESLint to 7.24.0

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 9, 2021
Trott
Trott approved these changes Apr 10, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@antsmartian antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 10, 2021
@cjihrig
tools: update ESLint to 7.24.0
28bca33 
Update ESLint to 7.24.0

PR-URL: nodejs#38179
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig cjihrig merged commit 28bca33 into nodejs:master Apr 12, 2021
@cjihrig cjihrig deleted the eslint branch April 12, 2021 03:55
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@cjihrig @targos
tools: update ESLint to 7.24.0
6b97bd7 
Update ESLint to 7.24.0

PR-URL: #38179
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@cjihrig @targos
tools: update ESLint to 7.24.0
6840a65 
Update ESLint to 7.24.0

PR-URL: #38179
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@cjihrig @targos
tools: update ESLint to 7.24.0
35d73fe 
Update ESLint to 7.24.0

PR-URL: #38179
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@cjihrig @targos
tools: update ESLint to 7.24.0
3fbabfa 
Update ESLint to 7.24.0

PR-URL: #38179
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @Trott @lpinca @aduh95 @antsmartian @targos @nodejs-github-bot