test,readline: improve tab completion coverage #38465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-ci
aduh95
added
readline
Trott
approved these changes
May 2, 2021
aduh95
force-pushed
the
readline-tab-completion-test-coverage
branch
from
b291d15 to
4e2ed40
Compare
aduh95
added
author ready
aduh95
added
blocked
aduh95
force-pushed
the
readline-tab-completion-test-coverage
branch
2 times, most recently
from
b291d15 to
b53eb32
Compare
aduh95
added
author ready
targos
approved these changes
May 2, 2021
PR-URL: nodejs#38465 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95
force-pushed
the
readline-tab-completion-test-coverage
branch
from
b53eb32 to
68e6673
Compare
|
Landed in 68e6673 |
targos
pushed a commit
that referenced
this pull request
May 3, 2021
PR-URL: #38465 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
May 30, 2021
PR-URL: #38465 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #38465 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #38465 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #38465 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #38464