v8: add date/time change notification

[jasnell]

This is an attempt at providing a workable solution for #4230 ....

V8 caches the timezone details. On windows, when process.env.TZ is changed, V8 is not picking up the changes. This PR introduces an API that can be used to tell V8 to clear it's cached timezone parameters. Whether this is going to work or not, I'm not yet sure as I'm having difficulty building on windows locally at the moment. We'll see what the CI has to say

Fixes: #4230
Signed-off-by: James M Snell jasnell@gmail.com

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/38028/

[jasnell]

Hmm ok, looks like clearing the cache doesn't always help...

https://ci.nodejs.org/job/node-test-commit-linux-containered/26975/nodes=ubuntu1804_sharedlibs_withoutssl_x64/testReport/junit/(root)/test/parallel_test_datetime_change_notify/

AssertionError [ERR_ASSERTION]: The input did not match the regular expression /GMT-05:00/. Input:

'Tue May 11 2021 18:42:16 GMT+0000 (GMT)'

    at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-datetime-change-notify.js:16:8)
    at Module._compile (node:internal/modules/cjs/loader:1109:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1138:10)
    at Module.load (node:internal/modules/cjs/loader:989:32)
    at Function.Module._load (node:internal/modules/cjs/loader:829:14)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12)
    at node:internal/main/run_main_module:17:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 'Tue May 11 2021 18:42:16 GMT+0000 (GMT)',
  expected: /GMT-05:00/,
  operator: 'match'
}

Interestingly, the test works fine on my local ubuntu image...

The failures appear to be limited to the CI jobs that run in containers... at least so far.

[jasnell]

Actually, it doesn't look like this is going to do the trick. I had missed that the datetime change notification was already being sent but it definitely does not seem to always be having any effect on Windows or some of the other machines. Hmmm.... Closing but will keep digging.