Skip to content

tools: update ESLint to 7.27.0 #38764

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 22, 2021

Update ESLint to 7.27.0

@github-actions github-actions bot added the tools Issues and PRs related to the tools directory. label May 22, 2021
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM assuming this was generated with the usual tools/updat-eslint.shscript. I certainly like the 44K lines removed.

@bl-ue
Copy link
Contributor

bl-ue commented May 25, 2021

Yeah, tasty crunch. 😋 Looks like they removed their lodash dependencies, that's why 🤔

eslint/eslint#14098 & eslint/eslint#14287 are the causes of this.

@kaizhu256
Copy link
Contributor

woot, lodash is a scourge that should be wiped from the planet.

lpinca added a commit that referenced this pull request May 26, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@lpinca
Copy link
Member Author

lpinca commented May 26, 2021

Landed in b6471c9.

@lpinca lpinca closed this May 26, 2021
@lpinca lpinca deleted the update/eslint branch May 26, 2021 16:22
targos pushed a commit that referenced this pull request May 30, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request May 31, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request May 31, 2021
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38764
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants