Skip to content

doc: add String.prototype.at and %TypedArray%.prototype.at #39583

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: add String.prototype.at and %TypedArray%.prototype.at #39583

wants to merge 1 commit into from

Conversation

ljharb
Copy link
Member

@ljharb ljharb commented Jul 30, 2021 •
edited
Loading

(ref: #39470, #38990)

@ljharb ljharb added the doc Issues and PRs related to the documentations. label Jul 30, 2021
@ljharb ljharb requested review from targos and BethGriggs July 30, 2021 00:04
@nodejs-github-bot nodejs-github-bot added the release Issues and PRs related to Node.js releases. label Jul 30, 2021
@Nixinova Nixinova mentioned this pull request Jul 30, 2021
Merged
@ljharb ljharb changed the title changelog: add String.prototype.at and %TypedArray%.prototype.at doc: add String.prototype.at and %TypedArray%.prototype.at Jul 30, 2021
@ljharb ljharb force-pushed the changelog-v16.6-tweak branch from 1060545 to 2967555 Compare July 30, 2021 03:26
@targos
Copy link
Member

targos commented Jul 30, 2021

If you also want to update the blog post on the website, it's here: https://github.com/nodejs/nodejs.org/blob/master/locale/en/blog/release/v16.6.0.md

@ljharb
Copy link
Member Author

ljharb commented Jul 30, 2021

oh ok, i assumed updating this file would automatically update the blog post

@ljharb ljharb mentioned this pull request Jul 30, 2021
Merged
@ljharb
Copy link
Member Author

ljharb commented Jul 30, 2021

nodejs/nodejs.org#4014

@BethGriggs BethGriggs added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 30, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @BethGriggs. Please 👍 to approve.

@BethGriggs BethGriggs added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 30, 2021
@github-actions
Copy link
Contributor

Landed in e99ba64...08ef0ae

@github-actions github-actions bot closed this Jul 30, 2021
nodejs-github-bot pushed a commit that referenced this pull request Jul 30, 2021
@ljharb @nodejs-github-bot
doc: add String.prototype.at and %TypedArray%.prototype.at
08ef0ae 
PR-URL: #39583
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
@ljharb ljharb deleted the changelog-v16.6-tweak branch July 30, 2021 15:11
danielleadams pushed a commit that referenced this pull request Aug 16, 2021
@ljharb @danielleadams
doc: add String.prototype.at and %TypedArray%.prototype.at
55f47cc 
PR-URL: #39583
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
@danielleadams danielleadams mentioned this pull request Aug 16, 2021
Merged
@targos targos removed the release Issues and PRs related to Node.js releases. label Sep 27, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@targos targos targos approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@AshCripps AshCripps AshCripps approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ljharb @targos @BethGriggs @AshCripps @nodejs-github-bot