Skip to content

crypto: fix webcrypto Curve25519 and Curve448 spki/pkcs8 imports #40131

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

crypto: fix webcrypto Curve25519 and Curve448 spki/pkcs8 imports #40131

wants to merge 2 commits into from

Conversation

panva
Copy link
Member

@panva panva commented Sep 16, 2021

Fixes the following webcrypto key algorithm' SPKI and PKCS8 imports

{ name: 'ECDH', namedCurve: 'NODE-X25519' }
{ name: 'ECDH', namedCurve: 'NODE-X448' }
{ name: 'NODE-ED25519', namedCurve: 'NODE-ED25519' }
{ name: 'NODE-ED448', namedCurve: 'NODE-ED448' }

@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto labels Sep 16, 2021
@panva panva requested a review from jasnell September 16, 2021 20:16
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 16, 2021
@panva panva requested a review from jasnell September 16, 2021 20:18
@panva panva added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels Sep 16, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2021
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@panva
Copy link
Member Author

panva commented Sep 16, 2021

cc @nodejs/crypto

@github-actions github-actions bot mentioned this pull request Sep 17, 2021
Open
18 tasks
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2021
@panva panva requested a review from tniessen September 17, 2021 15:40
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2021
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39985/

This was referenced Sep 18, 2021
Open
Open
Open
panva added a commit that referenced this pull request Sep 20, 2021
@panva
crypto: fix webcrypto ed(25519|448) spki/pkcs8 import
453bb6b 
PR-URL: #40131
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@panva
Copy link
Member Author

panva commented Sep 20, 2021

Landed in 453bb6b

@panva panva closed this Sep 20, 2021
@panva panva deleted the fix-ed-der-import branch September 20, 2021 09:38
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@panva @BethGriggs
crypto: fix webcrypto ed(25519|448) spki/pkcs8 import
e52867c 
PR-URL: #40131
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BethGriggs pushed a commit that referenced this pull request Sep 21, 2021
@panva @BethGriggs
crypto: fix webcrypto ed(25519|448) spki/pkcs8 import
f0dec58 
PR-URL: #40131
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BethGriggs BethGriggs mentioned this pull request Sep 21, 2021
Merged
1 task
This was referenced Sep 22, 2021
Open
Open
Open
Open
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. webcrypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@panva @nodejs-github-bot @jasnell @tniessen