Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tools: extend default yamllint config #40150

Closed
wants to merge 1 commit into from
Closed

tools: extend default yamllint config #40150

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Sep 19, 2021

No description provided.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 19, 2021
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 19, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 19, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/39998/

@github-actions github-actions bot mentioned this pull request Sep 20, 2021
Open
17 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40008/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 21, 2021
@github-actions
Copy link
Contributor

Landed in 549f968...f367af4

@github-actions github-actions bot closed this Sep 21, 2021
nodejs-github-bot pushed a commit that referenced this pull request Sep 21, 2021
@targos @nodejs-github-bot
tools: extend default yamllint config
f367af4 
PR-URL: #40150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 22, 2021
Open
Open
Open
Open
Open
Open
Open
targos added a commit that referenced this pull request Oct 4, 2021
@targos
tools: extend default yamllint config
ebf1710 
PR-URL: #40150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
@targos targos deleted the yammlint-default branch October 12, 2021 07:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@targos @nodejs-github-bot @jasnell @cjihrig @aduh95