-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
deps: upgrade to npm 2.14.12 #4033
Conversation
Should this be rolled into #4003? |
This one can actually supersede #4003, except without all the discussion. Want me to copy the description snippets related to 2.14.11 into the description for this one? |
@zkat sure, when you get time. |
@Fishrock123 oh right, you don't get notified for edits... this PR's description has been updated. :) |
@zkat I probably won't merge this until I figure out the potential legal stuff that has been brought up because I really don't understand what is all up. :( |
Ok, the license here looks better... I think? Maybe this wasn't subject of the concerns in #3959 because it isn't npm 3. Running the tests again now. |
@zkat I can't seem to apply this onto |
appears to be conflicts in a bunch of files... biggest offender appears to be
but here is a complete list of all the bits that are in conflict |
fwiw
seems to have kinda worked, I did have to manually add some deleted files at the end I'm currently running @zkat is this commit made by just replacing the folder on 4.x and committing it? |
seeing two failures in the test suite
|
Hey @zkat as per the discussion on IRC would you be able to reopen this against Sorry for the confusion |
Hiii!
This PR includes two releases:
The main thing to note is a hopefully welcome update to our licensing to clarify scope of both the open source side and the registry TOS. There's a further clarification coming later this week, so we're not done with that bit yet -- so keep an eye out for v2.14.13.
This PR supersedes #4003, but have a look-see over there for some discussion. That PR should be closeable, though.
r: @jasnell
r: @Fishrock123
r: @chrisdickinson