deps: suppress zlib compiler warnings #40343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Oct 6, 2021
richardlau
approved these changes
Oct 6, 2021
25 tasks
jasnell
approved these changes
Oct 7, 2021
This was referenced Oct 8, 2021
Currently, there are a number of compilation warnings from zlib like the
following one:
../deps/zlib/infback.c: In function ‘inflateBack’:
../deps/zlib/infback.c:479:25: warning:
this statement may fall through [-Wimplicit-fallthrough=]
479 | state->mode = LEN;
| ~~~~~~~~~~~~^~~~~
../deps/zlib/infback.c:481:9: note: here
481 | case LEN:
| ^~~~
In this case there is no break statement and the intention is to fall
through:
Tracev((stderr, "inflate: codes ok\n"));
state->mode = LEN;
case LEN:
This commit adds -Wno-implicit-fallthrough' to zlib.gyp to suppress
these warnings.
Move cflags into conditions section and only enable for non-windows architectures.
|
Re-run of failing /node-test-binary-windows-js-suites ✔️ |
danbev
added a commit
that referenced
this pull request
Oct 11, 2021
Currently, there are a number of compilation warnings from zlib like the
following one:
../deps/zlib/infback.c: In function ‘inflateBack’:
../deps/zlib/infback.c:479:25: warning:
this statement may fall through [-Wimplicit-fallthrough=]
479 | state->mode = LEN;
| ~~~~~~~~~~~~^~~~~
../deps/zlib/infback.c:481:9: note: here
481 | case LEN:
| ^~~~
In this case there is no break statement and the intention is to fall
through:
Tracev((stderr, "inflate: codes ok\n"));
state->mode = LEN;
case LEN:
This commit adds -Wno-implicit-fallthrough' to zlib.gyp to suppress
these warnings.
PR-URL: #40343
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 5d7bd86. |
22 tasks
targos
pushed a commit
that referenced
this pull request
Oct 13, 2021
Currently, there are a number of compilation warnings from zlib like the
following one:
../deps/zlib/infback.c: In function ‘inflateBack’:
../deps/zlib/infback.c:479:25: warning:
this statement may fall through [-Wimplicit-fallthrough=]
479 | state->mode = LEN;
| ~~~~~~~~~~~~^~~~~
../deps/zlib/infback.c:481:9: note: here
481 | case LEN:
| ^~~~
In this case there is no break statement and the intention is to fall
through:
Tracev((stderr, "inflate: codes ok\n"));
state->mode = LEN;
case LEN:
This commit adds -Wno-implicit-fallthrough' to zlib.gyp to suppress
these warnings.
PR-URL: #40343
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
22 tasks
2 tasks
This was referenced Oct 15, 2021
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are a number of compilation warnings from zlib like the
following one:
In this case there is no break statement and the intention is to fall
through:
This commit adds
-Wno-implicit-fallthroughto zlib.gyp to suppressthese warnings.