Skip to content

stream: remove no longer necessary ComposeDuplex #40545

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

stream: remove no longer necessary ComposeDuplex #40545

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 21, 2021

No description provided.

@ronag ronag added stream Issues and PRs related to the stream subsystem. dont-land-on-v12.x labels Oct 21, 2021
@ronag
Copy link
Member Author

ronag commented Oct 21, 2021

@nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 21, 2021
mcollina
mcollina approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 21, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40396/

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40398/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40400/

@ronag ronag removed the needs-ci PRs that need a full CI run. label Oct 21, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 21, 2021 •
edited by ronag
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/40402/ ✅

@github-actions github-actions bot mentioned this pull request Oct 22, 2021
Open
28 tasks
@github-actions github-actions bot mentioned this pull request Oct 23, 2021
Open
31 tasks
@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2021
@github-actions
Copy link
Contributor

Landed in 9843885...47fb867

@github-actions github-actions bot closed this Oct 23, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 23, 2021
@ronag @nodejs-github-bot
stream: remove no longer necessary ComposeDuplex
47fb867 
PR-URL: #40545
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This was referenced Oct 24, 2021
Open
Open
Open
Open
targos pushed a commit that referenced this pull request Nov 6, 2021
@ronag @targos
stream: remove no longer necessary ComposeDuplex
bac7fe0 
PR-URL: #40545
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@targos targos mentioned this pull request Nov 8, 2021
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ronag @nodejs-github-bot @mcollina @benjamingr @lpinca @tniessen