doc: final round of markdown format changes #40645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
Trott
force-pushed
the
final-ish-reformat
branch
2 times, most recently
from
3684f10 to
2836b1b
Compare
Adding |
aduh95
approved these changes
Oct 29, 2021
|
@aduh95 The new mdast-util-to-markdown results in far fewer of those |
Trott
force-pushed
the
final-ish-reformat
branch
from
2836b1b to
e600f8f
Compare
I kept the new changes in a separate commit so you can just review that commit if you want. |
Trott
force-pushed
the
final-ish-reformat
branch
from
e600f8f to
6d54218
Compare
aduh95
approved these changes
Oct 30, 2021
Trott
added
author ready
targos
approved these changes
Oct 31, 2021
Trott
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40645 ✔ Done loading data for nodejs/node/pull/40645 ----------------------------------- PR info ------------------------------------ Title doc: final round of markdown format changes (#40645) Author Rich Trott (@Trott) Branch Trott:final-ish-reformat -> nodejs:master Labels doc, tools, author ready Commits 2 - doc: final round of markdown format changes - tools: avoid unnecessary escaping in markdown formatter Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40645 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40645 Reviewed-By: Antoine du Hamel Reviewed-By: Michaël Zasso -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 29 Oct 2021 01:31:46 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40645#pullrequestreview-793647868 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40645#pullrequestreview-793701405 ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1404977948 |
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release. PR-URL: nodejs#40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Update mdast-util-to-markdown to 1.2.4 which reduces unnecessary escaping of `_` and some other characters. Re-run markdown formatter. PR-URL: nodejs#40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Trott
force-pushed
the
final-ish-reformat
branch
from
6d54218 to
86099a3
Compare
|
Landed in 1a6d927...86099a3 |
|
Now that this has landed, people who use Pinging everyone (aside from me) that has landed a commit manually in the last month: @targos @mhdawson @danbev @aduh95 @VoltrexMaster @joyeecheung @BethGriggs @danielleadams @guybedford @richardlau @lpinca @cjihrig @Ayase-252 @MylesBorins @RaisinTen @mscdex @codebytere @panva @Lxxyx |
richardlau
added a commit
to richardlau/node-core-utils
that referenced
this pull request
Nov 1, 2021
Upstream changes to the Node.js `CHANGELOG.md` no longer escape `_` characters in markdown links. Refs: nodejs/node#40645
targos
pushed a commit
to nodejs/node-core-utils
that referenced
this pull request
Nov 3, 2021
Upstream changes to the Node.js `CHANGELOG.md` no longer escape `_` characters in markdown links. Refs: nodejs/node#40645
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release. PR-URL: #40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
Update mdast-util-to-markdown to 1.2.4 which reduces unnecessary escaping of `_` and some other characters. Re-run markdown formatter. PR-URL: #40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 29, 2022
Once the README and find-inactive-collaborators.mjs changes land here, we can introduce markdown formatting as a step in the toolchain somewhere. Before this lands, nodejs/node-core-utils#578 will need to land and be included in a node-core-utils release. PR-URL: #40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 29, 2022
Update mdast-util-to-markdown to 1.2.4 which reduces unnecessary escaping of `_` and some other characters. Re-run markdown formatter. PR-URL: #40645 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
johnfrench3
pushed a commit
to johnfrench3/core-utils-node
that referenced
this pull request
Nov 2, 2022
Upstream changes to the Node.js `CHANGELOG.md` no longer escape `_` characters in markdown links. Refs: nodejs/node#40645
renawolford6
added a commit
to renawolford6/node-dev-build-core-utils
that referenced
this pull request
Nov 10, 2022
Upstream changes to the Node.js `CHANGELOG.md` no longer escape `_` characters in markdown links. Refs: nodejs/node#40645
Developerarif2
pushed a commit
to Developerarif2/node-core-utils
that referenced
this pull request
Jan 27, 2023
Upstream changes to the Node.js `CHANGELOG.md` no longer escape `_` characters in markdown links. Refs: nodejs/node#40645
gerkai
added a commit
to gerkai/node-core-utils-project-build
that referenced
this pull request
Jan 27, 2023
Upstream changes to the Node.js `CHANGELOG.md` no longer escape `_` characters in markdown links. Refs: nodejs/node#40645
patrickm68
added a commit
to patrickm68/NodeJS-core-utils
that referenced
this pull request
Sep 14, 2023
Upstream changes to the Node.js `CHANGELOG.md` no longer escape `_` characters in markdown links. Refs: nodejs/node#40645
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the README and find-inactive-collaborators.mjs changes land here,
we can introduce markdown formatting as a step in the toolchain
somewhere.
Before this lands, nodejs/node-core-utils#578
will need to land and be included in a node-core-utils release.