-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
deps: upgrade npm to 8.2.0 #41065
deps: upgrade npm to 8.2.0 #41065
Conversation
Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve. |
Another larger-than-normal diff on this one because we have refactored how logging works, namely by separating out terminal and file logging to their own concerns, and streaming to a logfile that is now always written even if npm exited cleanly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp LGTM
Commit Queue failed- Loading data for nodejs/node/pull/41065 ✔ Done loading data for nodejs/node/pull/41065 ----------------------------------- PR info ------------------------------------ Title deps: upgrade npm to 8.2.0 (#41065) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch npm-robot:npm-8.2.0 -> nodejs:master Labels npm, fast-track, needs-ci, dont-land-on-v12.x, dont-land-on-v14.x, lts-watch-v16.x Commits 1 - deps: upgrade npm to 8.2.0 Committers 1 - npm team PR-URL: https://github.com/nodejs/node/pull/41065 Fixes: https://github.com/add Fixes: https://github.com/always Reviewed-By: Myles Borins Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41065 Fixes: https://github.com/add Fixes: https://github.com/always Reviewed-By: Myles Borins Reviewed-By: Luigi Pinca Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 02 Dec 2021 22:04:48 GMT ✔ Approvals: 3 ✔ - Myles Borins (@MylesBorins) (TSC): https://github.com/nodejs/node/pull/41065#pullrequestreview-822168572 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41065#pullrequestreview-822428987 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41065#pullrequestreview-823349691 ℹ This PR is being fast-tracked ✔ Last GitHub Actions successful ℹ Last Full PR CI on 2021-12-04T16:49:27Z: https://ci.nodejs.org/job/node-test-pull-request/41334/ - Querying data for job/node-test-pull-request/41334/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD 147d23b211..6ef6bdf1fd master -> origin/master ✔ origin/master is now up-to-date master is out of sync with origin/master. Mismatched commits: - 3966111212 build: add `--without-corepack` - 6ef6bdf1fd build: add `--without-corepack` -------------------------------------------------------------------------------- HEAD is now at 6ef6bdf1fd build: add `--without-corepack` ✔ Reset to origin/master - Downloading patch for 41065 From https://github.com/nodejs/node * branch refs/pull/41065/merge -> FETCH_HEAD ✔ Fetched commits as 6ef6bdf1fd19..c2b5c0d7525c -------------------------------------------------------------------------------- [master 1f36fd9896] deps: upgrade npm to 8.2.0 Author: npm team Date: Thu Dec 2 22:04:46 2021 +0000 287 files changed, 5497 insertions(+), 5996 deletions(-) create mode 100644 deps/npm/docs/content/using-npm/logging.md create mode 100644 deps/npm/docs/output/using-npm/logging.html delete mode 100644 deps/npm/lib/utils/cleanup-log-files.js create mode 100644 deps/npm/lib/utils/display.js delete mode 100644 deps/npm/lib/utils/get-project-scope.js create mode 100644 deps/npm/lib/utils/log-file.js create mode 100644 deps/npm/lib/utils/log-shim.js delete mode 100644 deps/npm/lib/utils/proc-log-listener.js delete mode 100644 deps/npm/lib/utils/setup-log.js create mode 100644 deps/npm/lib/utils/timers.js create mode 100644 deps/npm/lib/utils/with-chown-sync.js create mode 100644 deps/npm/man/man7/logging.7 delete mode 100644 deps/npm/node_modules/code-point-at/index.js delete mode 100644 deps/npm/node_modules/code-point-at/license delete mode 100644 deps/npm/node_modules/code-point-at/package.json delete mode 100644 deps/npm/node_modules/code-point-at/readme.md delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/aproba/LICENSE delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/aproba/index.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/aproba/package.json delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/LICENSE delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/base-theme.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/error.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/has-color.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/index.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/package.json delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/plumbing.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/process.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/progress-bar.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/render-template.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/set-immediate.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/set-interval.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/spin.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/template-item.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/theme-set.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/themes.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/gauge/wide-truncate.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/is-fullwidth-code-point/index.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/is-fullwidth-code-point/license delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/is-fullwidth-code-point/package.json delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/npmlog/LICENSE delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/npmlog/log.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/npmlog/package.json delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/string-width/index.js delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/string-width/license delete mode 100644 deps/npm/node_modules/node-gyp/node_modules/string-width/package.json delete mode 100644 deps/npm/node_modules/npmlog/node_modules/are-we-there-yet/LICENSE.md delete mode 100644 deps/npm/node_modules/npmlog/node_modules/are-we-there-yet/lib/index.js delete mode 100644 deps/npm/node_modules/npmlog/node_modules/are-we-there-yet/lib/tracker-base.js delete mode 100644 deps/npm/node_modules/npmlog/node_modules/are-we-there-yet/lib/tracker-group.js delete mode 100644 deps/npm/node_modules/npmlog/node_modules/are-we-there-yet/lib/tracker-stream.js delete mode 100644 deps/npm/node_modules/npmlog/node_modules/are-we-there-yet/lib/tracker.js delete mode 100644 deps/npm/node_modules/npmlog/node_modules/are-we-there-yet/package.json delete mode 100644 deps/npm/node_modules/number-is-nan/index.js delete mode 100644 deps/npm/node_modules/number-is-nan/license delete mode 100644 deps/npm/node_modules/number-is-nan/package.json delete mode 100644 deps/npm/node_modules/number-is-nan/readme.md create mode 100644 deps/npm/tap-snapshots/test/lib/utils/log-file.js.test.cjs create mode 100644 deps/npm/test/fixtures/clean-snapshot.js create mode 100644 deps/npm/test/fixtures/mock-globals.js create mode 100644 deps/npm/test/fixtures/mock-logs.js rewrite deps/npm/test/fixtures/mock-npm.js (65%) rewrite deps/npm/test/lib/cli.js (63%) rewrite deps/npm/test/lib/commands/dedupe.js (69%) rewrite deps/npm/test/lib/commands/find-dupes.js (80%) rewrite deps/npm/test/lib/commands/prune.js (75%) rewrite deps/npm/test/lib/commands/version.js (82%) create mode 100644 deps/npm/test/lib/fixtures/mock-globals.js rewrite deps/npm/test/lib/load-all.js (70%) delete mode 100644 deps/npm/test/lib/utils/cleanup-log-files.js create mode 100644 deps/npm/test/lib/utils/display.js rewrite deps/npm/test/lib/utils/exit-handler.js (81%) delete mode 100644 deps/npm/test/lib/utils/get-project-scope.js rewrite deps/npm/test/lib/utils/is-windows-bash.js (65%) create mode 100644 deps/npm/test/lib/utils/log-file.js create mode 100644 deps/npm/test/lib/utils/log-shim.js delete mode 100644 deps/npm/test/lib/utils/proc-log-listener.js delete mode 100644 deps/npm/test/lib/utils/setup-log.js create mode 100644 deps/npm/test/lib/utils/timers.js ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- deps: upgrade npm to 8.2.0https://github.com/nodejs/node/actions/runs/1541037621 |
PR-URL: #41065 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Landed in b323cec |
PR-URL: #41065 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #41065 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #41065 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #41065 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: nodejs#41065 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #41065 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
v8.2.0 (2021-12-02)
Features
6734ba36d
#4062 feat: streaming debug logfile (@lukekarrys)Bug Fixes
5f4040aa0
chore: remove get-project-scope utils (@yuqu)c5c6d1603
#4060 fix: add missing scope on flat options (@yuqu)47828b766
chore: update one-time password prompt (@darcyclarke)Documentation
fc46a7926
#4072 docs: fix typo insave-peer
description (@chalkygames123)2fbf1576f
#4081 docs: Fix typo (@idleberg)a8bc95f11
#4089 docs(workspaces): Fix typo (@yotamselementor)31b098ee2
#4113 docs: add logging docs (@darcyclarke)cbae0fb71
#4114 docs: update description about where/when debug log is written (@lukekarrys)Dependencies
037f2cc8c
#4078node-gyp@8.4.1
0e63df612
#4102@npmcli/config@2.3.2
: