Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

domain: pass opts to EventEmitter.init #41414

Merged
merged 2 commits into from
Jan 19, 2022
Merged

domain: pass opts to EventEmitter.init #41414

merged 2 commits into from
Jan 19, 2022

Conversation

MoonBall
Copy link
Member

@MoonBall MoonBall commented Jan 5, 2022 •
edited by aduh95
Loading

The domain module override the EventEmitter.init but not pass the params to origin function.

Since repl module require domain module, the root cause of #41391 is in domain module.

Fixes: #41391

@nodejs-github-bot nodejs-github-bot added domain Issues and PRs related to the domain subsystem. needs-ci PRs that need a full CI run. labels Jan 5, 2022
apapirovski
apapirovski approved these changes Jan 6, 2022
View reviewed changes
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 6, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 6, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41776/

This was referenced Jan 7, 2022
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 14, 2022
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41876/

@github-actions github-actions bot mentioned this pull request Jan 15, 2022
Open
26 tasks
@CMCDragonkai CMCDragonkai mentioned this pull request Jan 16, 2022
Closed
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41953/

@github-actions github-actions bot mentioned this pull request Jan 18, 2022
Open
16 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42002/

@github-actions github-actions bot mentioned this pull request Jan 19, 2022
Open
13 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 19, 2022
@nodejs-github-bot nodejs-github-bot merged commit 22792c8 into nodejs:master Jan 19, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 22792c8

@github-actions github-actions bot mentioned this pull request Jan 20, 2022
Open
17 tasks
@CMCDragonkai
Copy link

Are fixes like these ever backported or only to LTS?

@aduh95
Copy link
Contributor

aduh95 commented Jan 20, 2022

This is semver-patch, it should be automatically backported to v17.x. Once there's a v17.x version with this change, it should be automatically backported to v16.x two weeks after that. If a conflict arises that blocks the backport, the backporter team usually comments on the issue asking for a manual backport.

BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@MoonBall @BethGriggs
domain: pass opts to EventEmitter.init
74bd312 
PR-URL: #41414
Fixes: #41391
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@MoonBall @Linkgoron
domain: pass opts to EventEmitter.init
212b1fd 
PR-URL: nodejs#41414
Fixes: nodejs#41391
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
danielleadams pushed a commit that referenced this pull request Feb 26, 2022
@MoonBall @danielleadams
domain: pass opts to EventEmitter.init
40ff0b5 
PR-URL: #41414
Fixes: #41391
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@MoonBall @danielleadams
domain: pass opts to EventEmitter.init
8758403 
PR-URL: #41414
Fixes: #41391
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@MoonBall @danielleadams
domain: pass opts to EventEmitter.init
227dea8 
PR-URL: #41414
Fixes: #41391
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@cjihrig cjihrig cjihrig approved these changes

@aduh95 aduh95 aduh95 approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. domain Issues and PRs related to the domain subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

「captureRejections」property works different in node REPL with node file.js
7 participants
@MoonBall @nodejs-github-bot @CMCDragonkai @aduh95 @apapirovski @cjihrig @ZYSzys