Skip to content

[v14.x backport] esm: make process.exit() default to exit code 0 #41508

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

[v14.x backport] esm: make process.exit() default to exit code 0 #41508

wants to merge 4 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 14, 2022

Due to a bug in top-level await implementation, it used to default to
exit code 13.

PR-URL: #41388
Fixes: #40808
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com
Reviewed-By: Guy Bedford guybedford@gmail.com

@MoonBall @aduh95
esm: make process.exit() default to exit code 0
968960d 
Due to a bug in top-level await implementation, it used to default to
exit code 13.

PR-URL: nodejs#41388
Fixes: nodejs#40808
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@aduh95 aduh95 added experimental Issues and PRs related to experimental features. esm Issues and PRs related to the ECMAScript Modules implementation. v14.x labels Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jan 14, 2022
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 14, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41881/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41882/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41883/

@github-actions github-actions bot mentioned this pull request Jan 15, 2022
Open
26 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41898/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41900/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 16, 2022 •
edited by richardlau
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/41925/ (✔️)

@github-actions github-actions bot mentioned this pull request Jan 18, 2022
Open
16 tasks
richardlau pushed a commit that referenced this pull request Jan 25, 2022
@MoonBall @richardlau
esm: make process.exit() default to exit code 0
a90defe 
Due to a bug in top-level await implementation, it used to default to
exit code 13.

PR-URL: #41388
Backport-PR-URL: #41508
Fixes: #40808
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
@richardlau
Copy link
Member

Landed in a90defe.

@richardlau richardlau closed this Jan 25, 2022
@aduh95 aduh95 deleted the backport-tla-process-exit-fix branch January 25, 2022 18:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@ljharb ljharb ljharb left review comments

@richardlau richardlau richardlau left review comments

@jkrems jkrems jkrems approved these changes

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. experimental Issues and PRs related to experimental features. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aduh95 @nodejs-github-bot @richardlau @ljharb @jkrems @guybedford @MoonBall