Skip to content

tools,test,lib: enable no-cond-assign ESLint rule #41614

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 23, 2022
Merged

tools,test,lib: enable no-cond-assign ESLint rule #41614

merged 9 commits into from
Jan 23, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 20, 2022

no-cond-assign is one of the few ESLint recommended rules that we have turned off. This change enables the rule.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 20, 2022
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. and removed lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 20, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 20, 2022
@nodejs-github-bot

This comment has been minimized.

# to view
@nodejs-github-bot

This comment has been minimized.

# to view
@tniessen
Copy link
Member

Technically, I think ESLint would also accept if ((a = b)) instead of if ((a = b) !== null), but I prefer the latter.

@Trott
Copy link
Member Author

Trott commented Jan 20, 2022 •
edited
Loading

Technically, I think ESLint would also accept if ((a = b)) instead of if ((a = b) !== null), but I prefer the latter.

Yeah, I feel the same. Adding the parentheses but nothing else would probably confuse a lot of people.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42046/

@Trott Trott marked this pull request as ready for review January 20, 2022 16:03
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 21, 2022
Trott added 9 commits January 22, 2022 19:38
@Trott
crypto: revise variables for const use instead of let
c05c883 
This prepares the code for enabling the no-cond-assign rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
stream: check for null instead of falsy in loops
e6fdcbe 
Check for null in while loops. This is preparing the code for
the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
policy: check for null instead of falsy in loop
0bc6422 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
process: check for null instead of falsy in while loop
e044a5d 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
timers: check for nullish instead of falsy in loops
bd42245 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
util: check for null instead of flasy in loop
ac06951 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
repl: check for precise values rather than falsy in loops
348469b 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
test: prepare tests for no-cond-assign ESLint rule
d77754b 
PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
tools: enable no-cond-assign-ESLint rule
68bb83f 
no-cond-assign is one of the few ESLint recommended rules that we have
turned off. This change enables the rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented Jan 23, 2022

Landed in fbfb61a...68bb83f

danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@Trott @danielleadams
test: prepare tests for no-cond-assign ESLint rule
3ba78ba 
PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Feb 28, 2022
@Trott @danielleadams
tools: enable no-cond-assign-ESLint rule
9f1711b 
no-cond-assign is one of the few ESLint recommended rules that we have
turned off. This change enables the rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
crypto: revise variables for const use instead of let
115f92c 
This prepares the code for enabling the no-cond-assign rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
stream: check for null instead of falsy in loops
f10fe12 
Check for null in while loops. This is preparing the code for
the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
policy: check for null instead of falsy in loop
5e69b19 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
process: check for null instead of falsy in while loop
396dfd7 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
timers: check for nullish instead of falsy in loops
171a7bd 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
util: check for null instead of flasy in loop
6106d6a 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
repl: check for precise values rather than falsy in loops
cdacc08 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
test: prepare tests for no-cond-assign ESLint rule
0fe9123 
PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
@Trott @danielleadams
tools: enable no-cond-assign-ESLint rule
582eda7 
no-cond-assign is one of the few ESLint recommended rules that we have
turned off. This change enables the rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request Mar 3, 2022
Merged
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
crypto: revise variables for const use instead of let
3307077 
This prepares the code for enabling the no-cond-assign rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
stream: check for null instead of falsy in loops
a90f4da 
Check for null in while loops. This is preparing the code for
the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
policy: check for null instead of falsy in loop
738d9f5 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
process: check for null instead of falsy in while loop
edc9291 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
timers: check for nullish instead of falsy in loops
6e9e3df 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
util: check for null instead of flasy in loop
fa4d848 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
repl: check for precise values rather than falsy in loops
39d3524 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
test: prepare tests for no-cond-assign ESLint rule
cf21ea5 
PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
@Trott @danielleadams
tools: enable no-cond-assign-ESLint rule
e1002cb 
no-cond-assign is one of the few ESLint recommended rules that we have
turned off. This change enables the rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
crypto: revise variables for const use instead of let
faceae4 
This prepares the code for enabling the no-cond-assign rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
stream: check for null instead of falsy in loops
363c760 
Check for null in while loops. This is preparing the code for
the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
policy: check for null instead of falsy in loop
33f3391 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
process: check for null instead of falsy in while loop
f066246 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
timers: check for nullish instead of falsy in loops
63a67f8 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
util: check for null instead of flasy in loop
a4ad26d 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
repl: check for precise values rather than falsy in loops
dacffd3 
This prepares the code for the no-cond-assign ESLint rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
test: prepare tests for no-cond-assign ESLint rule
b06c33b 
PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
@Trott @danielleadams
tools: enable no-cond-assign-ESLint rule
b17aa25 
no-cond-assign is one of the few ESLint recommended rules that we have
turned off. This change enables the rule.

PR-URL: #41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @tniessen @addaleax