stream: never flatten on toArray #41615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
benjamingr
force-pushed
the
stream-toArray-no-flatten-buffers
branch
from
7caff58 to
ee551bc
Compare
ronag
approved these changes
Jan 20, 2022
github-actions
bot
removed
the
request-ci
aduh95
approved these changes
Jan 20, 2022
19 tasks
benjamingr
added
the
author ready
This was referenced Jan 22, 2022
benjamingr
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ca48949 |
This was referenced Jan 24, 2022
BethGriggs
pushed a commit
that referenced
this pull request
Jan 25, 2022
PR-URL: #41615 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
PR-URL: nodejs#41615 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
danielleadams
added
the
semver-minor
This comment was marked as outdated.
This comment was marked as outdated.
danielleadams
added
backport-blocked-v16.x
and removed
semver-minor
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
PR-URL: #41615 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
PR-URL: #41615 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#41615 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
toArray()flattening behavior for non objectMode streams.See discussion here: #41612 (comment) and previous discussion here: #41553
cc @ronag @nodejs/streams