Skip to content

[v16.x backport] tools: update babel-eslint-parser to 7.16.0 #41770

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v16.x backport] tools: update babel-eslint-parser to 7.16.0 #41770

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 30, 2022

Backport of #40720

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v16.x labels Jan 30, 2022
@Trott Trott mentioned this pull request Jan 30, 2022
Closed
@Trott Trott requested a review from danielleadams January 30, 2022 14:47
@Trott Trott mentioned this pull request Jan 30, 2022
Merged
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42253/

This was referenced Jan 30, 2022
Closed
Closed
@github-actions github-actions bot mentioned this pull request Jan 31, 2022
Open
28 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42256/

@danielleadams danielleadams added the fast-track PRs that do not need to wait for 48 hours to land. label Jan 31, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @danielleadams. Please 👍 to approve.

@danielleadams
Copy link
Contributor

@Trott sorry - I had to do a hard rebase. are you able to drop the additional commits? I will hold the branch until I land this. Thank you!

Trott added 2 commits January 31, 2022 20:05
@Trott
test: add semicolons for linter update
7749e33 
Add missing semicolons that will be flagged when we update
@babel/eslint-parser to 7.16.0.

PR-URL: nodejs#40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
tools: update babel-eslint-parser to 7.16.0
72813b3 
PR-URL: nodejs#40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@Trott
Copy link
Member Author

Trott commented Jan 31, 2022

@Trott sorry - I had to do a hard rebase. are you able to drop the additional commits? I will hold the branch until I land this. Thank you!

All done!

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42277/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42283/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42284/

@github-actions github-actions bot mentioned this pull request Feb 1, 2022
Open
31 tasks
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
test: add semicolons for linter update
25b3187 
Add missing semicolons that will be flagged when we update
@babel/eslint-parser to 7.16.0.

PR-URL: #40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Backport-PR-URL: #41770
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
tools: update babel-eslint-parser to 7.16.0
ea75ef5 
PR-URL: #40720
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Backport-PR-URL: #41770
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
@danielleadams
Copy link
Contributor

Landed in 4e05026...ea75ef5

This was referenced Feb 2, 2022
Open
Open
Open
Open
@Trott Trott deleted the backport-1 branch September 25, 2022 17:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@danielleadams danielleadams danielleadams approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @danielleadams @lpinca