Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

readline: improve code coverage for readline promises #41817

Merged
merged 2 commits into from
Feb 5, 2022
Merged

readline: improve code coverage for readline promises #41817

merged 2 commits into from
Feb 5, 2022

Conversation

ErickWendel
Copy link
Member

@ErickWendel ErickWendel commented Feb 1, 2022 •
edited
Loading

It add tests to the readline promises module
Refs: lib/readline/promises.js.html#L42

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 1, 2022
cjihrig
cjihrig approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a tiny nit.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Feb 1, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42308/

@github-actions github-actions bot mentioned this pull request Feb 2, 2022
Open
38 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42314/

This was referenced Feb 3, 2022
Open
Open
Open
@benjamingr benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 5, 2022
@nodejs-github-bot nodejs-github-bot merged commit 92b85e7 into nodejs:master Feb 5, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 92b85e7

This was referenced Feb 6, 2022
Open
Open
ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
@ErickWendel @ruyadorno
readline: improve code coverage for readline promises
cbcf794 
PR-URL: #41817
Refs: https://coverage.nodejs.org/coverage-7123a00b03a90862/lib/readline/promises.js.html#L42
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
@danielleadams
Copy link
Contributor

danielleadams commented Mar 1, 2022 •
edited
Loading

Marking this as backport-blocked-v16.x as this lands on top of #41008, and pulling it in without breaks tests.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Lxxyx Lxxyx Lxxyx approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Mesteery Mesteery Mesteery approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@ErickWendel @nodejs-github-bot @danielleadams @benjamingr @lpinca @cjihrig @Lxxyx @aduh95 @Mesteery @targos