-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
deps: upgrade npm to 8.5.4 #42288
Closed
Closed
deps: upgrade npm to 8.5.4 #42288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve. |
Mesteery
approved these changes
Mar 10, 2022
Trott
approved these changes
Mar 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
ruyadorno
approved these changes
Mar 10, 2022
This comment was marked as outdated.
This comment was marked as outdated.
16 tasks
VoltrexKeyva
approved these changes
Mar 11, 2022
lpinca
approved these changes
Mar 11, 2022
This was referenced Mar 12, 2022
RaisinTen
approved these changes
Mar 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
28 tasks
Commit Queue failed- Loading data for nodejs/node/pull/42288 ✔ Done loading data for nodejs/node/pull/42288 ----------------------------------- PR info ------------------------------------ Title deps: upgrade npm to 8.5.4 (#42288) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch npm-robot:npm-8.5.4 -> nodejs:master Labels npm, fast-track, dont-land-on-v12.x, dont-land-on-v14.x Commits 1 - deps: upgrade npm to 8.5.4 Committers 1 - npm team PR-URL: https://github.com/nodejs/node/pull/42288 Fixes: https://github.com/clean Reviewed-By: Mestery Reviewed-By: Rich Trott Reviewed-By: Ruy Adorno Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42288 Fixes: https://github.com/clean Reviewed-By: Mestery Reviewed-By: Rich Trott Reviewed-By: Ruy Adorno Reviewed-By: Mohammed Keyvanzadeh Reviewed-By: Luigi Pinca Reviewed-By: Darshan Sen -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 10 Mar 2022 19:08:49 GMT ✔ Approvals: 6 ✔ - Mestery (@Mesteery): https://github.com/nodejs/node/pull/42288#pullrequestreview-906329579 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42288#pullrequestreview-906361109 ✔ - Ruy Adorno (@ruyadorno): https://github.com/nodejs/node/pull/42288#pullrequestreview-906391279 ✔ - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/42288#pullrequestreview-907016617 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42288#pullrequestreview-907623203 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42288#pullrequestreview-908156194 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-03-11T10:11:42Z: https://ci.nodejs.org/job/node-test-pull-request/42940/ - Querying data for job/node-test-pull-request/42940/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 42288 From https://github.com/nodejs/node * branch refs/pull/42288/merge -> FETCH_HEAD ✔ Fetched commits as a718ef91f462..3857be55d2bf -------------------------------------------------------------------------------- [master 0c333a45c3] deps: upgrade npm to 8.5.4 Author: npm team Date: Thu Mar 10 19:08:45 2022 +0000 53 files changed, 2306 insertions(+), 1398 deletions(-) rewrite deps/npm/lib/utils/otplease.js (68%) delete mode 100644 deps/npm/node_modules/gauge/lib/demo.js rewrite deps/npm/node_modules/make-fetch-happen/node_modules/lru-cache/bundle/main.js (96%) create mode 100644 deps/npm/tap-snapshots/test/lib/commands/doctor.js.test.cjs create mode 100644 deps/npm/test/fixtures/tnock.js rewrite deps/npm/test/lib/commands/doctor.js (98%) ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- deps: upgrade npm to 8.5.4https://github.com/nodejs/node/actions/runs/1981430462 |
20 tasks
closing in favor of #42382 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
fast-track
PRs that do not need to wait for 48 hours to land.
npm
Issues and PRs related to the npm client dependency or the npm registry.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v8.5.4 (2022-03-10)
Bug Fixes
fbdb43138
#4529 fix(rebuild): don't run lifecycle scripts twice on linked deps (@wraithgar)1c182e11d
#4495 fix(doctor): don't retry ping (@wraithgar)55ab38c53
#4495 fix(doctor): allow for missing local bin andnode_modules
(@wraithgar)5c06a33e6
#4528 fix: clean up owner command and otplease (@wraithgar)Documentation
2485064da
#4524 docs: fix typo in configuring-npm/package-json.md (@dlcmh)91f03ee61
#4510 docs: standardize changelog heading (@wraithgar)Dependencies
377f55e0e
#4530 deps:make-fetch-happen@10.0.5
40b7fbf67
#4531 deps:read-package-json@4.1.2
d9dc70ce4
#4545 deps:map-workspaces@2.0.2
EDUPLICATEWORKSPACE
70fcfb46b
deps:libnpmfund@3.0.1
621cd033f
deps:@npmcli/arborist@5.0.2
087fdc4cb
deps:libnpmpublish@6.0.1
d24c6d288
deps:libnpmhook@8.0.1
fa59830fc
deps:libnpmsearch@5.0.1
6d5f22b86
deps:libnpmexec@4.0.1
69ea54350
deps:libnpmaccess@6.0.1
4742d7cf3
deps:libnpmteam@4.0.1
fdd255ae9
deps:libnpmorg@4.0.1
ed41bc101
deps:libnpmdiff@4.0.1
21e241025
deps:libnpmversion@3.0.1
ec7f36ff9
deps:libnpmpack@4.0.1
ad4b56414
deps:gauge@4.0.3