test: fix timeout of test-heap-prof.js in riscv devices #42674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
In riscv hardware test-heap-prof.js caused timeout in test. Because of weak performance. So there is a need to set TIMEOUT_SCALEFACTOR for riscv too. Fixes: nodejs#40152
jasnell
approved these changes
Apr 13, 2022
|
Hello @ArchFeh, with this PR now approved, are there any open tasks or is it ready to be merged? |
Hi! I think it is ready to be merged. Thanks! |
|
Hello @jasnell! With this PR approved and ready, what are the outstanding steps required for it to be merged? |
|
oy, I would have expected this to have landed already :-/ ... I'll start a CI run again just to confirm but this should be able to land now. |
jasnell
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42674 ✔ Done loading data for nodejs/node/pull/42674 ----------------------------------- PR info ------------------------------------ Title test: fix timeout of test-heap-prof.js in riscv devices (#42674) Author Yu Gu (@ArchFeh, first-time contributor) Branch ArchFeh:riscv -> nodejs:main Labels build, test, tools, python, needs-ci Commits 1 - test: fix timeout of test-heap-prof.js in riscv devices Committers 1 - ArchFeh PR-URL: https://github.com/nodejs/node/pull/42674 Fixes: https://github.com/nodejs/node/issues/40152 Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42674 Fixes: https://github.com/nodejs/node/issues/40152 Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 09 Apr 2022 16:14:48 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42674#pullrequestreview-941119183 ✔ Last GitHub CI successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3168192279 |
github-actions
bot
removed
the
request-ci
This was referenced Oct 4, 2022
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 186745b |
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In riscv hardware test-heap-prof.js caused timeout in test because of weak performance. So there is a need to set TIMEOUT_SCALEFACTOR for riscv too.
Fixes: #40152