build,test: add proper support for IBM i #42689
Conversation
Python 3.9 on IBM i now properly returns "os400" for sys.platform instead of claiming to be AIX as it did previously. While the IBM i PASE environment is compatible with AIX, it is a subset and has numerous differences which makes it beneficial to distinguish, however this means that it now needs explicit support here.
|
Review requested:
|
nodejs-github-bot
added
build
|
These changes depend on related changes in nodejs/gyp-next#140 being pulled in (now released in gyp-next 0.11.0) as well as those changes being merged in to node-gyp and then merged in here. The v8 build changes use |
#42625 updated gyp-next here and included the IBM i changes in nodejs/gyp-next#140. Reviewing the separate node-gyp changes are on my list of things to do. |
|
Is this going to be finished at some point? |
|
I forgot about this and thought it had already been merged. We definitely want to get this in for Node 20. The gyp-next changes have already been pulled in as part of #44605 @dmabupt can you please bring it out of draft and rebase as-needed? We'll also need to get npm to update their copy of node-gyp with at least v9.2.0 and then get that version pulled in here. |
|
Looks like npm/cli already pulled in node-gyp 9.3.0 as of 9.1, but the version shipped here is 8.19.x. I'm not sure if that can be upgraded to 9.1 or if we'll need npm to update node-gyp in the 8.19 branch. |
|
npm will be soon updated to v9.x see #45395 |
|
Looks like npm has been upgraded to 9.1.2 so we should be good to go. @dmabupt can you unmark as draft and fix up conflicts please. |
|
I created a new PR #46510 to track this issue. Close this one. |
Python 3.9 on IBM i now properly returns "os400" for sys.platform
instead of claiming to be AIX as it did previously. While the IBM i PASE
environment is compatible with AIX, it is a subset and has numerous
differences which makes it beneficial to distinguish, however this means
that it now needs explicit support here.
Related PR: