Skip to content

doc: fix ESM JSON/data URL import example #42728

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2022
Merged

doc: fix ESM JSON/data URL import example #42728

merged 1 commit into from
Apr 14, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 14, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Apr 14, 2022
@Trott
Copy link
Member Author

Trott commented Apr 14, 2022 •
edited
Loading

Adding dont-land-on-v14x and dont-land-on-v12x as Node.js 14 and 12 do not seem to require the import assertion for the code to run (although they require the --experimental-json-modules flag, as does Node.js 16--including that information is probably best to put in a separate PR so that we can pick and choose which things to cherry-pick/backport to which release branches).

@aduh95 aduh95 added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @aduh95. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 14, 2022
@nodejs-github-bot nodejs-github-bot merged commit a058cef into nodejs:master Apr 14, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in a058cef

@Trott Trott deleted the import-assertion branch April 14, 2022 11:25
@BethGriggs BethGriggs mentioned this pull request Apr 14, 2022
Merged
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@Trott @xtx1130
doc: fix ESM JSON/data URL import example
e47a35f 
PR-URL: nodejs#42728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
juanarbol pushed a commit that referenced this pull request May 31, 2022
@Trott @juanarbol
doc: fix ESM JSON/data URL import example
7c700eb 
PR-URL: #42728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
danielleadams pushed a commit that referenced this pull request Jun 27, 2022
@Trott @danielleadams
doc: fix ESM JSON/data URL import example
17ea020 
PR-URL: #42728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
targos pushed a commit that referenced this pull request Jul 11, 2022
@Trott @targos
doc: fix ESM JSON/data URL import example
c728da6 
PR-URL: #42728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@Trott @targos
doc: fix ESM JSON/data URL import example
b6c23b0 
PR-URL: #42728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@Trott @guangwong
doc: fix ESM JSON/data URL import example
3a7d4f6 
PR-URL: nodejs/node#42728
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@BethGriggs BethGriggs BethGriggs approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @nodejs-github-bot @BethGriggs @aduh95