Skip to content

[v16.x backport] test: improve code coverage for streams/duplexify #42788

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v16.x backport] test: improve code coverage for streams/duplexify #42788

wants to merge 1 commit into from

Conversation

ErickWendel
Copy link
Member

Backport of #41862

/cc @danielleadams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 19, 2022
@danielleadams danielleadams added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 20, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @danielleadams. Please 👍 to approve.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43591/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43599/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43603/

This was referenced Apr 21, 2022
Open
Open
Open
@ErickWendel ErickWendel changed the base branch from master to v16.x-staging April 23, 2022 15:18
@ErickWendel ErickWendel changed the base branch from v16.x-staging to master April 23, 2022 15:18
This was referenced Apr 24, 2022
Open
Open
Open
@ErickWendel
Copy link
Member Author

is anything missing to approve on this PR?

@nodejs-github-bot

This comment was marked as outdated.

# to view
@nodejs-github-bot

This comment was marked as outdated.

# to view
This was referenced May 30, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44253/

This was referenced Jun 1, 2022
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44809/

@danielleadams
Copy link
Contributor

@nodejs/collaborators would anyone else be able to review this?

mcollina
mcollina approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/44819/

@danielleadams
Copy link
Contributor

@ErickWendel I just realized the base of this PR is pointed to main. Can you point it to v16.x-staging and then resolve the merge conflicts? Thank you!

@ErickWendel
Copy link
Member Author

@ErickWendel I just realized the base of this PR is pointed to main. Can you point it to v16.x-staging and then resolve the merge conflicts? Thank you!

Oh. I'm sorry about it. I'll do. This week is being crazy here but I'll trying doing it by the weekend

@ErickWendel
Copy link
Member Author

hey just a heads up. I'm back from vacations so I'll be working on this feature this week o/

@ErickWendel ErickWendel force-pushed the erick/backport-streams-improve-code-coverage branch from 7fd01a6 to 9bd0c30 Compare July 5, 2022 20:12
@ErickWendel ErickWendel changed the base branch from main to v16.x-staging July 5, 2022 20:12
@ErickWendel ErickWendel closed this Jul 5, 2022
@ErickWendel ErickWendel deleted the erick/backport-streams-improve-code-coverage branch July 5, 2022 20:15
@ErickWendel ErickWendel restored the erick/backport-streams-improve-code-coverage branch July 5, 2022 20:15
@ErickWendel ErickWendel reopened this Jul 5, 2022
@ErickWendel ErickWendel force-pushed the erick/backport-streams-improve-code-coverage branch from 9bd0c30 to 5bedc83 Compare July 5, 2022 20:25
@ErickWendel
Copy link
Member Author

Ready to go now 🤩

@Trott Trott force-pushed the erick/backport-streams-improve-code-coverage branch from 5bedc83 to e8d4384 Compare July 8, 2022 15:59
@targos
Copy link
Member

targos commented Jul 12, 2022

Thank you @ErickWendel. Landed in 4aa4f7c

@targos targos closed this Jul 12, 2022
targos pushed a commit that referenced this pull request Jul 12, 2022
@ErickWendel @targos
test: improve code coverage for streams/duplexify
4aa4f7c 
PR-URL: #41862
Backport-PR-URL: #42788
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Jul 31, 2022
@ErickWendel @targos
test: improve code coverage for streams/duplexify
147f99c 
PR-URL: #41862
Backport-PR-URL: #42788
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@ErickWendel @guangwong
test: improve code coverage for streams/duplexify
aae131c 
PR-URL: nodejs/node#41862
Backport-PR-URL: nodejs/node#42788
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@cclauss cclauss cclauss approved these changes

@danielleadams danielleadams danielleadams approved these changes

@himself65 himself65 himself65 approved these changes

@benjamingr benjamingr Awaiting requested review from benjamingr

@cjihrig cjihrig Awaiting requested review from cjihrig

@juanarbol juanarbol Awaiting requested review from juanarbol

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ErickWendel @nodejs-github-bot @danielleadams @targos @mcollina @cclauss @himself65 @juanarbol