Skip to content

test: fix parallel/test-dgram-udp6-link-local-address #42795

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

test: fix parallel/test-dgram-udp6-link-local-address #42795

merged 1 commit into from
Apr 28, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 20, 2022

Since #41431 landed, this test is always skipped because family is now an integer, not a string anymore.

Thanks @bl-ue for the report.

Refs: #41431

@aduh95 aduh95 added dont-land-on-v12.x request-ci Add this label to start a Jenkins CI on a PR. labels Apr 20, 2022
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 20, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 20, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43584/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2022
@github-actions github-actions bot mentioned this pull request Apr 21, 2022
Open
22 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43619/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43620/

This was referenced Apr 22, 2022
Open
Open
Open
Open
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 28, 2022
@nodejs-github-bot nodejs-github-bot merged commit 68fb0bf into nodejs:master Apr 28, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 68fb0bf

@aduh95 aduh95 deleted the fix-dgram-test branch April 28, 2022 19:03
targos pushed a commit that referenced this pull request May 2, 2022
@aduh95 @targos
test: fix parallel/test-dgram-udp6-link-local-address
3c796f8 
Refs: #41431

PR-URL: #42795
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 2, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @nodejs-github-bot @jasnell @lpinca