deps: update undici to 5.4.0 #43262

nodejs-github-bot · 2022-05-31T09:12:58Z

This is an automated update of undici to 5.4.0.

Notable Change: we dropped the limits on the forbidden headers in fetch() as a spec deviation for server-side implementations.

tniessen · 2022-05-31T10:50:16Z

There is a merge conflict here; maybe because there are two update commits in this PR?

panva · 2022-05-31T11:41:52Z

There is a merge conflict here; maybe because there are two update commits in this PR?

@nodejs/undici

Trott · 2022-05-31T12:51:35Z

There is a merge conflict here; maybe because there are two update commits in this PR?

I think I've seen this in other updates. After the authors or eslint updates are merged, I always delete the branch to avoid this. Notice that there are two commits here. So that's almost surely what happened here too.

Trott · 2022-05-31T12:54:25Z

There is a merge conflict here; maybe because there are two update commits in this PR?

I think I've seen this in other updates. After the authors or eslint updates are merged, I always delete the branch to avoid this. Notice that there are two commits here. So that's almost surely what happened here too.

Might be a good idea for someone to change all the update GitHub jobs to delete the existing branch before creating the pull request.

Trott · 2022-05-31T12:56:41Z

I fixed the branch with the following commands:

git checkout actions/tools-update-undici
git reset --hard upstream/actions/tools-update-undici
git rebase -i upstream/master
git push --force-with-lease upstream actions/tools-update-undici

mcollina

lgtm

nodejs-github-bot · 2022-05-31T15:22:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44256/

github-actions · 2022-05-31T21:18:45Z

Fast-track has been requested by @mcollina. Please 👍 to approve.

nodejs-github-bot · 2022-06-01T06:14:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44276/

nodejs-github-bot · 2022-06-01T14:08:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44293/

nodejs-github-bot · 2022-06-01T18:46:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44302/

nodejs-github-bot · 2022-06-01T20:32:37Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44304/

nodejs-github-bot · 2022-06-01T21:12:59Z

Landed in 921ef9b

PR-URL: #43262 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>

Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) #43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) #42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * deps: upgrade npm to 8.11.0 (npm team) #43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) #43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) #42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) #43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [#42740](#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: #43266

PR-URL: nodejs#43262 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>

Notable changes: * deps: update undici to 5.4.0 (Node.js GitHub Bot) nodejs#43262 * (SEMVER-MINOR) util: add parseArgs module (Benjamin Coe) nodejs#42675 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397 * deps: upgrade npm to 8.11.0 (npm team) nodejs#43210 * deps: patch V8 to 10.2.154.4 (Michaël Zasso) nodejs#43067 * (SEMVER-MINOR) deps: update V8 to 10.2.154.2 (Michaël Zasso) nodejs#42740 * (SEMVER-MINOR) fs: make params in writing methods optional (LiviaMedeiros) nodejs#42601 * (SEMVER-MINOR) http: add uniqueHeaders option to request and createServer (Paolo Insogna) nodejs#41397 * (SEMVER-MINOR) net: add ability to reset a tcp socket (pupilTong) nodejs#43112 * (SEMVER-MINOR) Revert "build: make x86 Windows support temporarily experimental" (Michaël Zasso) [nodejs#42740](nodejs#42740) * This means 32-bit Windows binaries are back with this release. PR-URL: nodejs#43266

PR-URL: #43262 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>

@kuriyosh

Notable changes: * deps: * update undici to 5.4.0 (Node.js GitHub Bot) #43262 * doc: * add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 * add @kuriyosh to collaborators (Yoshiki Kurihara) #42824 * add RafaelGSS to collaborators (RafaelGSS) #42718 * add @meixg to collaborators (Xuguang Mei) #42576

PR-URL: #43262 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>

@kuriyosh

Notable changes: crypto: * (SEMVER-MINOR) remove Node.js-specific webcrypto extensions (Filip Skokan) #43310 * (SEMVER-MINOR) add CFRG curves to Web Crypto API (Filip Skokan) #42507 * (SEMVER-MINOR) make authTagLength optional for CC20P1305 (Tobias Nießen) #42427 * (SEMVER-MINOR) align webcrypto RSA key import/export with other implementations (Filip Skokan) #42816 deps: * update undici to 5.4.0 (Node.js GitHub Bot) #43262 * update undici to 5.3.0 (Node.js GitHub Bot) #43197 dns: * (SEMVER-MINOR) export error code constants from `dns/promises` (Feng Yu) #43176 doc: * add F3n67u to collaborators (Feng Yu) #43953 * deprecate coercion to integer in process.exit (Daeyeon Jeong) #43738 * (SEMVER-MINOR) deprecate diagnostics_channel object subscribe method (Stephen Belanger) #42714 * add LiviaMedeiros to collaborators (LiviaMedeiros) #43039 * add @kuriyosh to collaborators (Yoshiki Kurihara) #42824 * add RafaelGSS to collaborators (RafaelGSS) #42718 * add @meixg to collaborators (Xuguang Mei) #42576 errors: * (SEMVER-MINOR) add support for cause in aborterror (James M Snell) #41008 esm: * (SEMVER-MINOR) add chaining to loaders (Jacob Smith) #42623 events: * (SEMVER-MINOR) expose CustomEvent on global with CLI flag (Daeyeon Jeong) #43885 * (SEMVER-MINOR) add `CustomEvent` (Daeyeon Jeong) #43514 * (SEMVER-MINOR) propagate abortsignal reason in new AbortError ctor in events (James M Snell) #41008 fs: * (SEMVER-MINOR) propagate abortsignal reason in new AbortSignal constructors (James M Snell) #41008 * (SEMVER-MINOR) make params in writing methods optional (LiviaMedeiros) #42601 * (SEMVER-MINOR) add `read(buffer[, options])` versions (LiviaMedeiros) #42768 http: * (SEMVER-MINOR) add drop request event for http server (theanarkh) #43806 * (SEMVER-MINOR) add diagnostics channel for http client (theanarkh) #43580 * (SEMVER-MINOR) add perf_hooks detail for http request and client (theanarkh) #43361 * (SEMVER-MINOR) add uniqueHeaders option to request and createServer (Paolo Insogna) #41397 http2: * (SEMVER-MINOR) propagate abortsignal reason in new AbortError constructor (James M Snell) #41008 * (SEMVER-MINOR) compat support for array headers (OneNail) #42901 lib: * (SEMVER-MINOR) propagate abortsignal reason in new AbortError constructor in blob (James M Snell) #41008 * (SEMVER-MINOR) add abortSignal.throwIfAborted() (James M Snell) #40951 * (SEMVER-MINOR) improved diagnostics_channel subscribe/unsubscribe (Stephen Belanger) #42714 module: * (SEMVER-MINOR) add isBuiltIn method (hemanth.hm) #43396 module,repl: * (SEMVER-MINOR) support 'node:'-only core modules (Colin Ihrig) #42325 net: * (SEMVER-MINOR) add drop event for net server (theanarkh) #43582 * (SEMVER-MINOR) add ability to reset a tcp socket (pupilTong) #43112 node-api: * (SEMVER-MINOR) emit uncaught-exception on unhandled tsfn callbacks (Chengzhong Wu) #36510 perf_hooks: * (SEMVER-MINOR) add PerformanceResourceTiming (RafaelGSS) #42725 report: * (SEMVER-MINOR) add more heap infos in process report (theanarkh) #43116 src: * (SEMVER-MINOR) add --openssl-legacy-provider option (Daniel Bevenius) #40478 * (SEMVER-MINOR) define fs.constants.S_IWUSR & S_IRUSR for Win (Liviu Ionescu) #42757 src,doc,test: * (SEMVER-MAJOR) add --openssl-shared-config option (Daniel Bevenius) #43124 stream: * (SEMVER-MINOR) use cause options in AbortError constructors (James M Snell) #41008 * (SEMVER-MINOR) add iterator helper find (Nitzan Uziely) #41849 * (SEMVER-MINOR) add writableAborted (Robert Nagy) #40802 test: * (SEMVER-MINOR) add initial test module (Colin Ihrig) #42325 test_runner: * (SEMVER-MINOR) expose `describe` and `it` (Moshe Atlow) #43420 * (SEMVER-MINOR) add initial CLI runner (Colin Ihrig) #42658 * (SEMVER-MINOR) support 'only' tests (Colin Ihrig) #42514 timers: * (SEMVER-MINOR) propagate signal.reason in awaitable timers (James M Snell) #41008 util: * (SEMVER-MINOR) add tokens to parseArgs (John Gee) #43459 * (SEMVER-MINOR) add parseArgs module (Benjamin Coe) #42675 v8: * (SEMVER-MINOR) add v8.startupSnapshot utils (Joyee Cheung) #43329 * (SEMVER-MINOR) export more fields in getHeapStatistics (theanarkh) #42784 worker: * (SEMVER-MINOR) add hasRef() to MessagePort (Darshan Sen) #42849 PR-URL: TODO

PR-URL: nodejs/node#43262 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels May 31, 2022

deps: update undici to 5.4.0

38ecb99

Trott force-pushed the actions/tools-update-undici branch from c33f2de to 38ecb99 Compare May 31, 2022 12:55

panva approved these changes May 31, 2022

View reviewed changes

Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels May 31, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 31, 2022

This comment was marked as outdated.

# to view

mcollina approved these changes May 31, 2022

View reviewed changes

richardlau approved these changes May 31, 2022

View reviewed changes

tniessen approved these changes May 31, 2022

View reviewed changes

RaisinTen approved these changes May 31, 2022

View reviewed changes

mcollina added the notable-change PRs with changes that should be highlighted in changelogs. label May 31, 2022

mcollina mentioned this pull request May 31, 2022

v18.3.0 proposal #43266

Merged

mcollina added the fast-track PRs that do not need to wait for 48 hours to land. label May 31, 2022

github-actions bot mentioned this pull request Jun 1, 2022

CI Reliability 2022-06-01 nodejs/reliability#295

Open

17 tasks

mcollina added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jun 1, 2022

mcollina added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 1, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 1, 2022

nodejs-github-bot merged commit 921ef9b into master Jun 1, 2022

aduh95 deleted the actions/tools-update-undici branch June 1, 2022 21:52

github-actions bot mentioned this pull request Jun 2, 2022

CI Reliability 2022-06-02 nodejs/reliability#296

Open

19 tasks

This was referenced Jun 3, 2022

CI Reliability 2022-06-03 nodejs/reliability#297

Open

CI Reliability 2022-06-04 nodejs/reliability#298

Open

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update undici to 5.4.0 #43262

deps: update undici to 5.4.0 #43262

nodejs-github-bot commented May 31, 2022 •

edited by mcollina

Loading

tniessen commented May 31, 2022

panva commented May 31, 2022

Trott commented May 31, 2022

Trott commented May 31, 2022

Trott commented May 31, 2022 •

edited

Loading

This comment was marked as outdated.

mcollina left a comment

nodejs-github-bot commented May 31, 2022

github-actions bot commented May 31, 2022

nodejs-github-bot commented Jun 1, 2022

nodejs-github-bot commented Jun 1, 2022

nodejs-github-bot commented Jun 1, 2022

nodejs-github-bot commented Jun 1, 2022

nodejs-github-bot commented Jun 1, 2022

deps: update undici to 5.4.0 #43262

deps: update undici to 5.4.0 #43262

Conversation

nodejs-github-bot commented May 31, 2022 • edited by mcollina Loading

tniessen commented May 31, 2022

panva commented May 31, 2022

Trott commented May 31, 2022

Trott commented May 31, 2022

Trott commented May 31, 2022 • edited Loading

This comment was marked as outdated.

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented May 31, 2022

github-actions bot commented May 31, 2022

nodejs-github-bot commented Jun 1, 2022

nodejs-github-bot commented Jun 1, 2022

nodejs-github-bot commented Jun 1, 2022

nodejs-github-bot commented Jun 1, 2022

nodejs-github-bot commented Jun 1, 2022

nodejs-github-bot commented May 31, 2022 •

edited by mcollina

Loading

Trott commented May 31, 2022 •

edited

Loading